artemist/yuzu
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity
14542 commits 1 branch 0 tags 106 MiB
Commit graph

12771 commits

Author SHA1 Message Date
Lioncash 7e585bce28 memory/slab_heap: Make use of static_cast over reinterpret_cast 
Casting from void* with static_cast is permitted by the standard, so we
can just make use of that instead.
 2020-04-17 19:38:59 -04:00
Lioncash 441a2812ed loader/nso: Resolve moves not occurring in DecompressSegment 
Given the std::vector was const, an automatic move out of the function
could not occur.

We can allow automatic return value optimizations to occur by making the
buffer non-const.
 2020-04-17 19:26:50 -04:00
Lioncash 64f226889c am: Resolve ineffective moves 
Previously const objects were being std::moved, which results in no move
actually occurring. This resolves that.
 2020-04-17 19:22:46 -04:00
Markus Wick 07fbef1776 video_code: Fix implicit switch fallthrough. 
Since yesterday, this breaks the build on linux.
So let's fix it.
 2020-04-17 23:43:35 +02:00
ReinUsesLisp a7b6bd56d7 vk_stream_buffer: Fix out of memory on boot on recent Nvidia drivers 
Nvidia recently introduced a new memory type for data streaming
(awesome!), but yuzu was assuming that all heaps had enough memory
for the assumed stream buffer size (256 MiB).

This worked fine on AMD but Nvidia's new memory heap was smaller than
256 MiB. This commit changes this assumption and allocates a bit less
than the size of the preferred heap, with a maximum of 256 MiB (to avoid
allocating all system memory on integrated devices).

- Fixes a crash on NVIDIA 450.82.0.0
 2020-04-17 18:12:48 -03:00
Fernando Sahmkow 2133482a17
Merge pull request #3703 from yuzu-emu/revert-3656-glsl-full-decompile 
Revert "gl_shader_cache: Use CompileDepth::FullDecompile on GLSL"
 2020-04-17 17:08:41 -04:00
Fernando Sahmkow 775ecc7d05
Merge pull request #3672 from lioncash/null 
file_util: Early-exit in WriteArray and ReadArray if specified lengths are zero
 2020-04-17 17:02:35 -04:00
Rodrigo Locatti 990c0b184f
Revert "gl_shader_cache: Use CompileDepth::FullDecompile on GLSL" 2020-04-17 17:41:48 -03:00
bunnei b8f5c71f2d
Merge pull request #3666 from bunnei/new-vmm 
Implement a new virtual memory manager
 2020-04-17 16:33:08 -04:00
bunnei ca3af2961c
Merge pull request #3682 from lioncash/uam 
gl_query_cache: Resolve use-after-move in CachedQuery move assignment operator
 2020-04-17 01:24:08 -04:00
bunnei 8bbe74a8dc core: hle: Address various feedback & code cleanup. 
- Should be no functional changes.
 2020-04-17 00:59:36 -04:00
bunnei 92caa003a8 core: device_memory: Remove incorrect usage of constexpr. 2020-04-17 00:59:36 -04:00
bunnei 6f3266e98b memory: Add copyright notice for Atmosphere where applicable. 2020-04-17 00:59:35 -04:00
bunnei 02547a0cb4 kernel: Remove old VMManager class. 2020-04-17 00:59:35 -04:00
bunnei bebfb05c1b loader: nso: Fix loader size and arguments. 2020-04-17 00:59:35 -04:00
bunnei 83761d5316 loader: elf/kip/nro: Updates for new VMM. 2020-04-17 00:59:35 -04:00
bunnei 37b79ebe85 service: ldr: Updates for new VMM. 
- Includes removing some service impls. that are untested.
 2020-04-17 00:59:35 -04:00
bunnei a8292f6cd9 kernel: memory: page_table: Simplify GetPhysicalAddr impl. 2020-04-17 00:59:35 -04:00
bunnei c629e544a7 kernel: svc: Updates for new VMM. 
- Includes removing some SVC impls. that are untested.
 2020-04-17 00:59:34 -04:00
bunnei ff5d5b6f41 core: memory: Fix memory access on page boundaries. 
- Fixes Super Smash Bros. Ultimate.
 2020-04-17 00:59:34 -04:00
bunnei 32fc2aae3c video_core: memory_manager: Updates for Common::PageTable changes. 2020-04-17 00:59:34 -04:00
bunnei f7c03610e1 core: memory: Updates for new VMM. 2020-04-17 00:59:34 -04:00
bunnei 4c1812ae37 common: page_table: Update to use VirtualBuffer and simplify. 2020-04-17 00:59:34 -04:00
bunnei 1d5923e150 core: gdbstub: Updates for new VMM. 2020-04-17 00:59:34 -04:00
bunnei c7bc7986bb core: reporter: Updates for new VMM. 2020-04-17 00:59:33 -04:00
bunnei 18c4bb6f5c memory: cheat_engine: Updates for new VMM. 2020-04-17 00:59:33 -04:00
bunnei d95ceaa8ec arm_test_common: Updates for new VMM. 2020-04-17 00:59:33 -04:00
bunnei 108564df57 kernel: process: Updates for new VMM. 2020-04-17 00:59:33 -04:00
bunnei 77382ac2b2 service: pl_u: Update for new shared memory layout. 2020-04-17 00:59:33 -04:00
bunnei 67b3df683b service: time: Update for new shared memory layout. 2020-04-17 00:59:33 -04:00
bunnei 8eca0f9cd2 service: hid: Update for new shared memory layout. 2020-04-17 00:59:33 -04:00
bunnei 8bbc38a7bd service: irs: Update for new shared memory layout. 2020-04-17 00:59:32 -04:00
bunnei fc61cb44ee kernel: resource_limit: Reserve physical memory. 2020-04-17 00:59:32 -04:00
bunnei 8f75524e55 kernel: Initialize memory layout for new VMM. 2020-04-17 00:59:32 -04:00
bunnei 11c02a50e9 core: system: Rename GetDeviceManager -> DeviceManager. 
- More consistent with other system components.
 2020-04-17 00:59:32 -04:00
bunnei 3fcc4cab4f kernel: transfer_memory: Refactor for new VMM. 2020-04-17 00:59:32 -04:00
bunnei c53454ff46 core: Construct/Destruct DeviceMemory on Init/Shutdown. 2020-04-17 00:59:32 -04:00
bunnei d0162fc3d7 kernel: shared_memory: Refactor for new VMM. 2020-04-17 00:59:32 -04:00
bunnei a040a15246 core: device_memory: Update to use VirtualBuffer class. 2020-04-17 00:59:31 -04:00
bunnei 4ba2428c86 common: Add VirtualBuffer class, to abstract memory virtualization. 2020-04-17 00:59:31 -04:00
bunnei a238d08f71 kernel: errors: Add ERR_OUT_OF_RESOURCES. 2020-04-17 00:59:31 -04:00
bunnei ffc3de762b kernel: process_capability: Update to use Memory::PageTable. 2020-04-17 00:59:31 -04:00
bunnei 84f1b6d530 kernel: memory: Add PageTable class, to manage process address space. 2020-04-17 00:59:31 -04:00
bunnei cfae8a1c1a kernel: memory: Add MemoryLayout class, to build physical memory layout. 2020-04-17 00:59:31 -04:00
bunnei 5d6e8a5b44 kernel: memory: Add MemoryManager class, to manage page heaps. 2020-04-17 00:59:30 -04:00
bunnei 548ef190ab kernel: memory: Add MemoryBlockManager class, to manage memory blocks. 2020-04-17 00:59:30 -04:00
bunnei 3927012734 kernel: memory: Add PageHeap class, to manage a heap of pages. 2020-04-17 00:59:30 -04:00
bunnei dc720311cc kernel: memory: Add PageLinkedList class, to manage a list of pages. 2020-04-17 00:59:30 -04:00
bunnei 81cb4d3c7f kernel: memory: Add system_control code, which will be used for ASLR support. 2020-04-17 00:59:30 -04:00
bunnei fc040b5b70 physical_memory: Add missing include for <vector>. 2020-04-17 00:59:30 -04:00
bunnei c2f4dcb1e3 kernel: memory: Add MemoryBlock class, for managing memory blocks and their state. 2020-04-17 00:59:29 -04:00
bunnei ea5ee9918e kernel: memory: Add memory_types.h, for things that are commonly used in memory code. 2020-04-17 00:59:29 -04:00
bunnei d364e7cf09 kernel: memory: Add SlabHeap class, for managing memory heaps. 
- This will be used for TLS pages, among other things.
 2020-04-17 00:59:29 -04:00
bunnei 14aa65ce00 kernel: memory: Add AddressSpaceInfo class, for managing the memory address space. 2020-04-17 00:59:29 -04:00
bunnei dc25c86556 core: device_manager: Add a simple class to manage device RAM. 2020-04-17 00:59:29 -04:00
bunnei f1b607829e dynarmic: Enable strict alignment checks. 
- Also add a missing include.
 2020-04-17 00:59:29 -04:00
bunnei 4df6ef04ac common: scope_exit: Implement mechanism for canceling a scope exit. 2020-04-17 00:59:28 -04:00
bunnei 4caff51710 core: memory: Move to Core::Memory namespace. 
- helpful to disambiguate Kernel::Memory namespace.
 2020-04-17 00:59:28 -04:00
bunnei b838e58d63 common: alignment: Add a helper function for generic alignment checking. 2020-04-17 00:59:28 -04:00
bunnei ad48ebb2c8 core: kernel: Add svc_types header to include SVC-specific types. 2020-04-17 00:59:28 -04:00
bunnei 82d457af37 core: kernel: Move SVC to its own namesapce. 2020-04-17 00:59:28 -04:00
bunnei b0e3cbef7a kernel: resource_limit: Improvements to implementation. 2020-04-17 00:59:27 -04:00
bunnei 7aa0e4a7ca loader: nso: Fix loading of static objects to be properly sized and aligned. 2020-04-17 00:59:27 -04:00
bunnei b11b424a2d common: common_funcs: Add a macro for defining enum flag operators. 2020-04-17 00:59:27 -04:00
bunnei f2676efe23 process: SetupMainThread: Zero out argument on process start. 2020-04-17 00:11:50 -04:00
bunnei 0f4f90cd04 arm_interface: Ensure ThreadContext is zero'd out. 2020-04-17 00:11:50 -04:00
Lioncash dcbb39cdae CMakeLists: Make missing declarations a compile-time error 
Ensures that our code always has its linkage explicit.
 2020-04-16 23:43:41 -04:00
Lioncash e2d8be1ca2 General: Resolve warnings related to missing declarations 2020-04-16 23:43:34 -04:00
MerryMage 1cc9507bc5 gdbstub: Fix some gdbstub jankiness 
1. Ensure that register information available to gdbstub is most up-to-date.
2. There's no reason to check for current_thread == thread when emitting a trap.
   Doing this results in random hangs whenever a step happens upon a thread switch.
 2020-04-17 05:41:43 +02:00
bunnei 86f9c9aa1c
Merge pull request #3671 from lioncash/switch 
kernel/thread: Resolve -Wswitch warnings
 2020-04-16 23:30:32 -04:00
Lioncash 8f9c599c9f key_manager: Resolve missing field initializer warning 2020-04-16 22:45:44 -04:00
Lioncash 678ac54749 decode/memory: Resolve unused variable warning 
Only the first element of the returned pair is ever used.
 2020-04-16 22:45:44 -04:00
Lioncash d159643fd7 decode/texture: Resolve unused variable warnings. 
Some variables aren't used, so we can remove these.

Unfortunately, diagnostics are still reported on structured bindings
even when annotated with [[maybe_unused]], so we need to unpack the
elements that we want to use manually.
 2020-04-16 22:45:41 -04:00
Lioncash f522abd8ab decode/texture: Collapse loop down into std::generate 
Same behavior, less code.
 2020-04-16 22:29:07 -04:00
Lioncash 7e2d60de26 decode/texture: Eliminate trivial missing field initializer warnings 
We can just specify the initializers.
 2020-04-16 22:27:21 -04:00
Lioncash 337f2dc11f time_zone_manager: Resolve sign conversion warnings 
ttis and ats will never exceed the length of INT32_MAX in our case, so
this is safe.
 2020-04-16 22:23:59 -04:00
Lioncash fc5df84581 CMakeLists: Enable -Wmissing-declarations on Linux builds 
Allows catching cases where internal linkage isn't specified for helper
functions when they should be marked as such.
 2020-04-16 22:07:16 -04:00
Lioncash 77356731a9 hle_ipc: Remove std::size_t casts where applicable 
These were added in the change that enabled -Wextra on linux builds so
as not to introduce interface changes in the same change as a
build-system flag addition.

Now that the flags are enabled, we can freely change the interface to
make these unnecessary.
 2020-04-16 22:02:10 -04:00
bunnei 79c1269f0f
Merge pull request #3673 from lioncash/extra 
CMakeLists: Specify -Wextra on linux builds
 2020-04-16 21:12:33 -04:00
ReinUsesLisp 238c6016f9 maxwell_3d: Initialize format attributes constant as one 
nouveau expects this to be true but it doesn't set it.
 2020-04-16 21:15:07 -03:00
ReinUsesLisp c961770900 vk_compute_pass: Implement indexed quads 
Implement indexed quads (GL_QUADS used with glDrawElements*) with a
compute pass conversion.

The compute shader converts from uint8/uint16/uint32 indices to uint32.
The format is passed through push constants to avoid having different
variants of the same shader.

- Used by Fast RMX
- Used by Xenoblade Chronicles 2 (it still has graphical due to
synchronization issues on Vulkan)
 2020-04-16 21:12:32 -03:00
Fernando Sahmkow c81f256111
Merge pull request #3600 from ReinUsesLisp/no-pointer-buf-cache 
buffer_cache: Return handles instead of pointer to handles
 2020-04-16 19:58:13 -04:00
Markus Wick fedf750e1b externals: Move LibreSSL linking to httplib. 
Neither core nor web_services use OpenSSL nor LibreSSL.
However they need to link them as it's a requirement of httplib.
So let's declare this within httplib instead of core and web_services.
 2020-04-16 16:46:33 +02:00
Markus Wick 94c2c828a5 input_common: Use the CMake target instead of the variable. 2020-04-16 16:42:59 +02:00
Rodrigo Locatti db67e017cb
Merge pull request #3659 from bunnei/time-calc-standard-user 
service: time: Implement CalculateStandardUserSystemClockDifferenceByUser.
 2020-04-16 02:51:57 -03:00
ReinUsesLisp 090fd3fefa buffer_cache: Return handles instead of pointer to handles 
The original idea of returning pointers is that handles can be moved.
The problem is that the implementation didn't take that in mind and made
everything harder to work with. This commit drops pointer to handles and
returns the handles themselves. While it is still true that handles can
be invalidated, this way we get an old handle instead of a dangling
pointer.

This problem can be solved in the future with sparse buffers.
 2020-04-16 02:33:34 -03:00
Rodrigo Locatti a5a2ee8766
Merge pull request #3689 from lioncash/unused-var 
decode/shift: Remove unused variable within Shift()
 2020-04-16 02:05:54 -03:00
Rodrigo Locatti d196ce0f71
Merge pull request #3688 from lioncash/nequal 
surface_view: Add missing operator!= to ViewParams
 2020-04-16 01:39:51 -03:00
Rodrigo Locatti 4209dba1f6
Merge pull request #3680 from lioncash/static 
gl_device: Mark stage_swizzle as constexpr
 2020-04-16 01:26:23 -03:00
Rodrigo Locatti 60e8de7c95
Merge pull request #3687 from lioncash/constness 
surface_base: Make IsInside() a const member function
 2020-04-16 01:22:50 -03:00
Rodrigo Locatti 612966399b
Merge pull request #3685 from lioncash/copies 
control_flow: Make use of std::move in TryInspectAddress()
 2020-04-16 01:22:40 -03:00
Lioncash cd2a12e78f decode/shift: Remove unused variable within Shift() 
Removes a redundant variable that is already satisfied by the IsFull()
utility function.
 2020-04-16 00:16:06 -04:00
Lioncash 5fbe8785d2 surface_view: Add missing operator!= to ViewParams 
Provides logical symmetry to the interface.
 2020-04-16 00:03:12 -04:00
Lioncash d551c910bb surface_base: Make IsInside() a const member function 
This doesn't modify internal state, so this can be made const.
 2020-04-15 23:59:35 -04:00
bunnei 319df1db77
Merge pull request #3683 from lioncash/docs 
video_core: Amend doxygen comment references
 2020-04-15 23:54:58 -04:00
Lioncash 636c8ab85b texture_cache/format_lookup_table: Fix incorrect green, blue, and alpha indices 
Previously these were all using the red component to derive the indices,
which is definitely not intentional.
 2020-04-15 23:50:46 -04:00
Lioncash 72a224d3fc control_flow: Make use of std::move in TryInspectAddress() 
Eliminates redundant atomic reference count increments and decrements.
 2020-04-15 23:31:22 -04:00
Lioncash 11837e8f13 video_core: Amend doxygen comment references 
Fixes broken documentation references.
 2020-04-15 22:33:29 -04:00
Lioncash 3a60f19eaf gl_query_cache: Resolve use-after-move in CachedQuery move assignment operator 
Avoids potential invalid junk data from being read.
 2020-04-15 22:20:06 -04:00
Lioncash 71fb156611 gl_device: Mark stage_swizzle as constexpr 
Previously this was mutable even though it shouldn't be.
 2020-04-15 21:59:13 -04:00
Lioncash e15ec2705c track: Eliminate redundant copies 
Two variables can be references, while two others can be std::moved.
Makes for 4 less atomic reference count increments and decrements.
 2020-04-15 21:50:09 -04:00
Lioncash 1c340c6efa CMakeLists: Specify -Wextra on linux builds 
Allows reporting more cases where logic errors may exist, such as
implicit fallthrough cases, etc.

We currently ignore unused parameters, since we currently have many
cases where this is intentional (virtual interfaces).

While we're at it, we can also tidy up any existing code that causes
warnings. This also uncovered a few bugs as well.
 2020-04-15 21:33:46 -04:00
Rodrigo Locatti 65cbb122ea
Merge pull request #3649 from FernandoS27/3d-fix 
Texture Cache: Read current data when flushing a 3D segment.
 2020-04-15 17:06:55 -03:00
Fernando Sahmkow e33196d4e7
Merge pull request #3612 from ReinUsesLisp/red 
shader/memory: Implement RED.E.ADD and minor changes to ATOM
 2020-04-15 15:03:49 -04:00
Lioncash e77337588e file_util: Early-exit in WriteArray and ReadArray if specified lengths are zero 
It's undefined behavior to pass a null pointer to std::fread and
std::fwrite, even if the length passed in is zero, so we must perform
the precondition checking ourselves.

A common case where this can occur is when passing in the data of an
empty std::vector and size, as an empty vector will typically have a
null internal buffer.

While we're at it, we can move the implementation out of line and add
debug checks against passing in nullptr to std::fread and std::fwrite.
 2020-04-15 14:43:37 -04:00
Lioncash 213fff67bc CMakeLists: Make -Wreorder a compile-time error 
This can result in silent logic bugs within code, and given the amount
of times these kind of warnings are caused, they should be flagged at
compile-time so no new code is submitted with them.
 2020-04-15 14:14:41 -04:00
Lioncash 521c4c33b5 kernel/thread: Resolve -Wswitch warnings 2020-04-15 13:48:14 -04:00
Mat M 64b5985f0a
Merge pull request #3662 from ReinUsesLisp/constant-attrs 
gl_rasterizer: Implement constant vertex attributes
 2020-04-15 11:54:50 -04:00
Fernando Sahmkow 6789d88a9c Texture Cache: Read current data when flushing a 3D segment. 
This PR corrects flushing of 3D segments when data of other segments is
mixed, this aims to preserve the data in place.
 2020-04-15 11:46:17 -04:00
Mat M 9208d555b7
Merge pull request #3668 from ReinUsesLisp/vtx-format-16ui 
maxwell_to_vk: Add uint16 vertex formats
 2020-04-15 11:43:52 -04:00
Mat M ab72696beb
Merge pull request #3656 from ReinUsesLisp/glsl-full-decompile 
gl_shader_cache: Use CompileDepth::FullDecompile on GLSL
 2020-04-15 03:17:46 -04:00
Mat M 4878d6bb49
Merge pull request #3654 from ReinUsesLisp/fix-fb-attach 
gl_texture_cache: Fix layered texture attachment base level
 2020-04-15 03:17:18 -04:00
Mat M 50c0a92db8
Merge pull request #3663 from ReinUsesLisp/fcmp-rc 
shader/arithmetic: Add FCMP_CR variant
 2020-04-15 03:16:56 -04:00
Mat M 13331a3a32
Merge pull request #3664 from ReinUsesLisp/fe3h-black-squares 
Revert "gl_shader_decompiler: Implement merges with bitfieldInsert"
 2020-04-15 03:14:28 -04:00
ReinUsesLisp 3036067047 maxwell_to_vk: Add uint16 vertex formats 2020-04-15 04:06:30 -03:00
ReinUsesLisp b4e43c64c8 maxwell_to_vk: Add missing breaks 
Avoid invalid fallbacks.
 2020-04-15 04:05:33 -03:00
ReinUsesLisp 0ca456830f vk_blit_screen: Initialize all members in VkPipelineViewportStateCreateInfo 
When the dynamic state is specified, pViewports and pScissors are
ignored, quoting the specification:

  pViewports is a pointer to an array of VkViewport structures, defining
  the viewport transforms. If the viewport state is dynamic, this member
  is ignored.

That said, AMD's proprietary driver itself seem to read it regardless of
what the specification says.
 2020-04-15 03:30:08 -03:00
Rodrigo Locatti 0b132e8cc1
Merge pull request #3657 from ReinUsesLisp/viewport-zero 
vk_rasterizer: Default to 1 viewports with a size of 0
 2020-04-15 01:51:17 -03:00
Fernando Sahmkow daddbeffd1
Texture Cache: Only do buffer copies on accurate GPU. (#3634) 
This is a simple optimization as Buffer Copies are mostly used for texture recycling. They are, however, useful when games abuse undefined behavior but most 3D APIs forbid it.
 2020-04-14 23:21:00 -04:00
bunnei eb676c343a service: time: Implement CalculateStandardUserSystemClockDifferenceByUser. 
- Used by Animal Crossing: New Horizons.
 2020-04-14 22:28:41 -04:00
ReinUsesLisp fd6371eba7 Revert "gl_shader_decompiler: Implement merges with bitfieldInsert" 
This reverts commit 05cf270836.

Apparently the first approach using floats instead of bitfieldInert
worked better for Fire Emblem: Three Houses. Reverting to get that
behavior back.
 2020-04-14 21:24:33 -03:00
ReinUsesLisp fefe7f18f9 shader/arithmetic: Add FCMP_CR variant 
Adds another variant of FCMP.
 2020-04-14 19:11:04 -03:00
Zach Hilman e366b4ee1f
Merge pull request #3660 from bunnei/friend-blocked-users 
service: friend: Stub IFriendService::GetBlockedUserListIds.
 2020-04-14 16:59:46 -04:00
ReinUsesLisp 6dfcabc800 gl_rasterizer: Implement constant vertex attributes 
Credits go to gdkchan from Ryujinx for finding constant attributes are
used in retail games.
 2020-04-14 17:58:53 -03:00
bunnei fc35803f91 file_sys: patch_manager: Return early when there are no layers to apply. 2020-04-14 16:25:55 -04:00
bunnei 598740f1dd service: friend: Stub IFriendService::GetBlockedUserListIds. 
- This is safe to stub, as there should be no adverse consequences from reporting no blocked users.
 2020-04-14 16:20:51 -04:00
ReinUsesLisp 37e5c4fa7c vk_rasterizer: Default to 1 viewports with a size of 0 
Silence validation layer errors.
 2020-04-14 04:44:34 -03:00
ReinUsesLisp 453d7419d9 gl_shader_cache: Use CompileDepth::FullDecompile on GLSL 
From my testing on a Splatoon 2 shader that takes 3800ms on average to
compile changing to FullDecompile reduces it to 900ms on average.

The shader decoder will automatically fallback to a more naive method if
it can't use full decompile.
 2020-04-14 01:34:20 -03:00
ReinUsesLisp 0e232cfdc1 renderer_vulkan: Integrate Nvidia Nsight Aftermath on Windows 
Adds optional support for Nsight Aftermath. It is enabled through
ENABLE_NSIGHT_AFTERMATH in cmake. A path to the SDK has to be provided
by the environment variable NSIGHT_AFTERMATH_SDK.

Nsight Aftermath allows an application to generate "minidumps" of the
GPU state when a device loss happens. By analysing these on Nsight we
can know what a game was doing and why it triggered a device loss.

The dump is generated inside %APPDATA%\yuzu\log\gpucrash and this
directory is deleted every time a new instance is initialized with
Nsight enabled.

To enable it on yuzu there has a to be a driver and device capable of
running Nsight Aftermath on Vulkan. That means only Turing based GPUs
on the latest stable driver, beta drivers won't work for now.

It is manually enabled in Configuration>Debug>Enable Graphics Debugging
because when using all debugging capabilities there is a runtime cost.
 2020-04-14 00:39:21 -03:00
FearlessTobi c2bf91156a yuzu/main: Add better popup texts and remove duplicated actions 
Makes popup texts more compact and clear and also links our quickstart guide now.
Also removes OnMenuSelectEmulatedDirectory from the File dropdown, as the action already exists in the Filesystem tab and provides better visual feedback there.
 2020-04-14 02:56:22 +02:00
ReinUsesLisp 21dc842171 gl_texture_cache: Fix layered texture attachment base level 
The base level is already included in the texture view. If we specify
the base level in the texture again, this will end up in the incorrect
level and potentially out of bounds.
 2020-04-13 18:24:56 -03:00
ReinUsesLisp 6cfe2a7246 renderer_vulkan: Remove Nvidia checkpoints 2020-04-13 17:33:59 -03:00
ReinUsesLisp 16105c6a66 renderer_vulkan: Catch device losses in more places 2020-04-13 17:33:59 -03:00
Rodrigo Locatti 7e4a132a77
Merge pull request #3636 from ReinUsesLisp/drop-vk-hpp 
renderer_vulkan: Drop Vulkan-Hpp
 2020-04-13 17:08:04 -03:00
Mat M fbf13d3f48
Merge pull request #3651 from ReinUsesLisp/line-widths 
gl_rasterizer: Implement line widths and smooth lines
 2020-04-13 10:19:59 -04:00
Mat M 08266d70ba
Merge pull request #3638 from ReinUsesLisp/remove-preserve-contents 
texture_cache: Remove preserve_contents
 2020-04-13 10:19:01 -04:00
Mat M c4001225f6
Merge pull request #3631 from ReinUsesLisp/more-astc 
texture/astc: More small ASTC optimizations
 2020-04-13 10:17:32 -04:00
Mat M 7b62212461
Merge pull request #3619 from ReinUsesLisp/i2i 
shader/conversion: Implement I2I sign extension, saturation and selection
 2020-04-13 10:17:07 -04:00
Mat M 3351e1e94f
Merge pull request #3627 from ReinUsesLisp/layered-view 
gl_texture_cache: Attach view instead of base texture for layered attchments
 2020-04-13 10:16:18 -04:00
Mat M d37d899431
Merge pull request #3646 from ReinUsesLisp/fix-glsl-turing 
gl_shader_decompiler: Improve generated code in HMergeH*
 2020-04-13 10:15:12 -04:00
Mat M 47036859eb
Merge pull request #3633 from ReinUsesLisp/clean-texdec 
shader/texture: Remove type mismatches management from shader decoder
 2020-04-13 10:13:05 -04:00
ReinUsesLisp 76615b9f34 gl_rasterizer: Implement line widths and smooth lines 
Implements "legacy" features from OpenGL present on hardware such as
smooth lines and line width.
 2020-04-13 01:30:34 -03:00
ReinUsesLisp 05cf270836 gl_shader_decompiler: Implement merges with bitfieldInsert 
This also fixes Turing issues but it avoids doing more bitcasts. This
should improve the generated code while also avoiding more points where
compilers can flush floats.
 2020-04-12 22:39:59 -03:00
bunnei a9f866264d
Merge pull request #3606 from ReinUsesLisp/nvflinger 
service/vi: Partially implement BufferQueue disconnect
 2020-04-12 11:44:48 -04:00
Fernando Sahmkow 3d91dbb21d
Merge pull request #3578 from ReinUsesLisp/vmnmx 
shader/video: Partially implement VMNMX
 2020-04-12 10:44:03 -04:00
Mat M 4aec01b850
Merge pull request #3644 from ReinUsesLisp/msaa 
video_core: Add MSAA registers in 3D engine and TIC
 2020-04-12 09:11:44 -04:00
ReinUsesLisp 75eb953575 gl_shader_decompiler: Improve generated code in HMergeH* 
Avoiding bitwise expressions, this fixes Turing issues in shaders using
half float merges that affected several games.
 2020-04-12 05:06:55 -03:00
ReinUsesLisp 76f178ba6e shader/video: Partially implement VMNMX 
Implements the common usages for VMNMX. Inputs with a different size
than 32 bits are not supported and sign mismatches aren't supported
either.

VMNMX works as follows:
It grabs Ra and Rb and applies a maximum/minimum on them (this is
defined by .MX), having in mind the input sign. This result can then be
saturated. After the intermediate result is calculated, it applies
another operation on it using Rc. These operations are merges,
accumulations or another min/max pass.

This instruction allows to implement with a more flexible approach GCN's
min3 and max3 instructions (for instance).
 2020-04-12 00:34:42 -03:00
ReinUsesLisp a7baf6fee4 video_core: Add MSAA registers in 3D engine and TIC 
This adds the registers used for multisampling. It doesn't implement
anything for now.
 2020-04-12 00:21:27 -03:00
Rodrigo Locatti 75e39f7f88
Merge pull request #3635 from FernandoS27/buffer-free 
Buffer queue: Correct behavior of free buffer.
 2020-04-11 17:58:15 -03:00
bunnei 8938f9941c
Merge pull request #3611 from FearlessTobi/port-4956 
Port citra-emu/citra#4956: "Fixes to game list sorting"
 2020-04-11 12:44:36 -04:00
ReinUsesLisp 94b0e2e5da texture_cache: Remove preserve_contents 
preserve_contents was always true. We can't assume we don't have to
preserve clears because scissored and color masked clears exist.

This removes preserve_contents and assumes it as true at all times.
 2020-04-11 01:51:02 -03:00
ReinUsesLisp 2905142f47 renderer_vulkan: Drop Vulkan-Hpp 2020-04-10 22:49:02 -03:00
bunnei 51c6688e21
Merge pull request #3594 from ReinUsesLisp/vk-instance 
yuzu: Drop SDL2 and Qt frontend Vulkan requirements
 2020-04-10 20:06:55 -04:00
Fernando Sahmkow 486a42c45a Buffer queue: Correct behavior of free buffer. 
This corrects the behavior of free buffer after witnessing it in an
unrelated hardware test. I haven't found any games affected by it but in
name of better accuracy we'll correct such behavior.
 2020-04-10 16:44:28 -04:00
bunnei 8adf66f9fd
Merge pull request #3607 from FearlessTobi/input-kms 
yuzu/configuration: Fix input profiles and a wrong assert
 2020-04-10 00:39:48 -04:00
ReinUsesLisp 8c0ba9c6fe service/vi: Partially implement BufferQueue disconnect 2020-04-10 01:00:50 -03:00
ReinUsesLisp a87b16da9a shader/texture: Remove type mismatches management from shader decoder 
Since commit e22816a5bb we handle type mismatches from the CPU.
We don't need to hack our shader decoder due to game bugs anymore.

Removed in this commit.
 2020-04-10 00:57:32 -03:00
Fernando Sahmkow f570b129a2
Merge pull request #3623 from ReinUsesLisp/renderdoc-bind-spam 
qt/bootmanager: Remove unnecessary glBindFramebuffer
 2020-04-09 18:02:17 -04:00
Fernando Sahmkow 7182ef31c9
Merge pull request #3622 from ReinUsesLisp/srgb-texture-border 
video_core/texture: Use a LUT to convert sRGB texture borders
 2020-04-09 18:01:48 -04:00
ReinUsesLisp 6bf5d2b011 astc: Hard code bit depth changes to 8 and use fast replicate 2020-04-09 18:37:12 -03:00
Rodrigo Locatti 36f607217f
Merge pull request #3610 from FernandoS27/gpu-caches 
Refactor all the GPU Caches to use VAddr for cache addressing
 2020-04-09 17:59:21 -03:00
Ben Russell f98a2c42de
common/file_util: Allow access to files on network shares 
On Windows, network shares use paths like \\server\share\file which were
being broken by FileUtil::SanitizePath() removing double slashes.

Changed the code in SanitizePath to permit a double-backslash if it
occurs at the start of a filepath (on Windows only).
 2020-04-09 18:48:28 +01:00
ReinUsesLisp bd2c1ab8a0 astc: Use boost's static_vector to avoid heap allocations 2020-04-09 05:27:57 -03:00
ReinUsesLisp 5de130beea astc: Implement a fast precompiled alternative for Replicate 2020-04-09 03:58:25 -03:00
ReinUsesLisp 6b4d4473be astc: Move Replicate to a constexpr LUT when possible 2020-04-09 03:35:07 -03:00
ReinUsesLisp d22a689250 astc: Make InputBitStream constexpr 2020-04-09 02:54:05 -03:00
ReinUsesLisp 0efc230381 astc: OutputBitStream style changes and make it constexpr 2020-04-09 02:37:51 -03:00
bunnei b96fd0bd0e
Merge pull request #3601 from ReinUsesLisp/some-shader-encodings 
video_core/shader: Add some instruction and S2R encodings
 2020-04-09 00:17:39 -04:00
ReinUsesLisp 6c8f9f40d7 gl_texture_cache: Attach view instead of base texture for layered attachments 
This way we are not ignoring the base layer of the current texture.
 2020-04-08 22:20:25 -03:00
Fernando Sahmkow 7cd6daf115 VkRasterizer: Eliminate Legacy code. 2020-04-08 18:59:09 -04:00
Fernando Sahmkow 1c18dc6577 Memory: Correct GCC errors. 2020-04-08 18:09:16 -04:00
Fernando Sahmkow 913f42a3a7 Memory: Address Feedback. 2020-04-08 13:40:46 -04:00
Fernando Sahmkow e00d992848 GPUMemoryManager: Improve safety of memory reads. 2020-04-08 12:08:06 -04:00
Kewlan 848d619aec Place SL and SR in the right most column. 2020-04-08 11:34:16 +02:00
bunnei b128beb3a9
Merge pull request #3572 from FearlessTobi/port-5127 
Port citra-emu/citra#5127: "common: Port some changes from dolphin"
 2020-04-07 23:48:16 -04:00
ReinUsesLisp c6ea0d010b qt/bootmanager: Remove unnecessary glBindFramebuffer 
Presentation context always has GL_DRAW_FRAMEBUFFER_BINDING as zero.
There is no need to bind the default framebuffer constantly.

According to Nsight this was using ~0.7ms per frame and it broke
renderdoc captures.
 2020-04-07 20:51:56 -03:00
ReinUsesLisp a209d464f9 video_core/textures: Move GetMaxAnisotropy to cpp file 2020-04-07 20:47:31 -03:00
ReinUsesLisp d7db088180 video_core/texture: Use a LUT to convert sRGB texture borders 
This is a reversed look up table extracted from
https://gist.github.com/rygorous/2203834#file-gistfile1-cpp-L41-L62

that is used in
04d4e9e587/source/maxwell/tsc_generate.cpp (L38)

Games usually bind 0xFD expecting a float texture border of 1.0f.
The conversion previous to this commit was multiplying the uint8 sRGB
texture border color by 255. This is close to 1.0f but when that
difference matters, some graphical glitches appear.

This look up table is manually changed in the edges, clamping towards
0.0f and 1.0f.

While we are at it, move this logic to its own translation unit.
 2020-04-07 20:38:14 -03:00
Zach Hilman 26ed65495d
Merge pull request #3621 from SilverBeamx/fullnamefix 
Log version and about section version fix
 2020-04-07 17:16:23 -04:00
SilverBeamx 863f7385dc Addressed feedback: switched to snake case and fixed clang-format errors 2020-04-07 22:59:09 +02:00
bunnei f316911248
Merge pull request #3599 from ReinUsesLisp/revert-3499 
Revert "Merge pull request #3499 from ReinUsesLisp/depth-2d-array"
 2020-04-07 16:51:41 -04:00
SilverBeamx 6b512d78c9 Addressed feedback: removed CMake hack in favor of building the necessary strings via the supplied title format 2020-04-07 22:41:45 +02:00
ReinUsesLisp bf1d66b7c0 yuzu: Drop SDL2 and Qt frontend Vulkan requirements 
Create Vulkan instances and surfaces from the Vulkan backend.
 2020-04-07 16:32:19 -03:00
Rodrigo Locatti 487f9ba525
Merge pull request #3489 from namkazt/patch-2 
shader: implement SULD.D bits32/64
 2020-04-07 16:21:09 -03:00
Nguyen Dac Nam 935648ffa9
address nit. 2020-04-07 18:29:30 +07:00
ReinUsesLisp bc1b4b85b0 renderer_vulkan: Query device names from the backend 2020-04-07 02:23:23 -03:00
ReinUsesLisp 7104e01bb3 common/dynamic_library: Import and adapt helper from Dolphin 2020-04-07 02:23:23 -03:00
ReinUsesLisp da706cad25 shader/conversion: Implement I2I sign extension, saturation and selection 
Reimplements I2I adding sign extension, saturation (clamp source value
to the destination), selection and destination sizes that are not 32
bits wide.

It doesn't implement CC yet.
 2020-04-07 02:19:44 -03:00
Nguyen Dac Nam bf1174c114
Apply suggestions from code review 
Co-Authored-By: Rodrigo Locatti <reinuseslisp@airmail.cc>
 2020-04-07 07:55:49 +07:00
enler 27f122c48c
file_sys: fix LayeredFS error when loading some games made with… (#3602) 
* fix LayeredFS error when loading some games made with the Unity
 2020-04-07 02:03:32 +02:00
Fernando Sahmkow f9d5718c4b Clang Format. 2020-04-06 09:23:08 -04:00
Fernando Sahmkow ea535d9470 Shader/Pipeline Cache: Use VAddr instead of physical memory for addressing. 2020-04-06 09:23:07 -04:00
Fernando Sahmkow 3dd5c07454 Query Cache: Use VAddr instead of physical memory for adressing. 2020-04-06 09:23:07 -04:00
Fernando Sahmkow 7fcd0fee6d Buffer Cache: Use vAddr instead of physical memory. 2020-04-06 09:23:06 -04:00
Fernando Sahmkow 6ee316cb8f Texture Cache: Use vAddr instead of physical memory for caching. 2020-04-06 09:23:05 -04:00
Fernando Sahmkow 9c0f40a1f5 GPU: Setup Flush/Invalidate to use VAddr instead of CacheAddr 2020-04-06 09:21:46 -04:00
Fernando Sahmkow 588a20be3f
Merge pull request #3513 from ReinUsesLisp/native-astc 
video_core: Use native ASTC when available
 2020-04-06 09:21:11 -04:00
namkazy 2c98e14d13 shader_decode: SULD.D using std::pair instead of out parameter 2020-04-06 13:46:55 +07:00
namkazy 9efa51311f shader_decode: SULD.D avoid duplicate code block. 2020-04-06 13:34:06 +07:00