artemist/yuzu
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity
16522 commits 1 branch 0 tags 106 MiB
Commit graph

49 commits

Author SHA1 Message Date
Lioncash 677a8b208d video_core: Resolve more variable shadowing scenarios 
Resolves variable shadowing scenarios up to the end of the OpenGL code
to make it nicer to review. The rest will be resolved in a following
commit.
 2020-12-04 16:19:09 -05:00
Lioncash ff45c39578 General: Make use of std::nullopt where applicable 
Allows some implementations to avoid completely zeroing out the internal
buffer of the optional, and instead only set the validity byte within
the structure.

This also makes it consistent how we return empty optionals.
 2020-09-22 17:32:33 -04:00
Lioncash a5dcccfdd2 externals: Update Xbyak to 5.96 
I made a request on the Xbyak issue tracker to allow some constructors
to be constexpr in order to avoid static constructors from needing to
execute for some of our register constants.

This request was implemented, so this updates Xbyak so that we can make
use of it.
 2020-08-30 05:09:48 -04:00
bunnei bb752df736
Merge pull request #4542 from ReinUsesLisp/gpu-init-base 
video_core: Initialize renderer with a GPU
 2020-08-24 22:56:11 -04:00
ReinUsesLisp da53bcee60 video_core: Initialize renderer with a GPU 
Add an extra step in GPU initialization to be able to initialize render
backends with a valid GPU instance.
 2020-08-22 01:51:45 -03:00
Lioncash 34ec64233a macro-interpreter: Resolve -Wself-assign-field warning 
This was assigning the field to itself, which is a no-op. The size
doesn't change between its initial assignment and this one, so this is a
safe change to make.
 2020-08-14 08:26:50 -04:00
Lioncash e17fb5ee97 video_core: Remove unused variables 
Silences several compiler warnings about unused variables.
 2020-07-21 00:57:25 -04:00
LC 47956a3bbc
Merge pull request #4369 from lioncash/hle-macro 
macro_hle: Remove unnecessary std::make_pair calls
 2020-07-17 05:20:41 -04:00
Lioncash c0650cd82c macro_hle: Remove unnecessary static keywords 
These functions are already in an anonymous namespace which makes the
functions internally linked.
 2020-07-16 23:17:17 -04:00
David 9cca0c2f83
Merge pull request #4368 from lioncash/macro 
macro: Resolve missing parameter in doxygen comment
 2020-07-17 13:13:22 +10:00
Lioncash be6b7591d9 macro_hle: Simplify shift expression in HLE_771BB18C62444DA0() 
Given the expression involves a 32-bit value, this simplifies down to
just: 0x3ffffff. This is likely a remnant from testing that was never
cleaned up.

Resolves a -Wshift-overflow warning.
 2020-07-16 22:16:11 -04:00
Lioncash cc935d997b macro_hle: Remove unnecessary std::make_pair calls 
The purpose of make_pair is generally to deduce the types within the
pair without explicitly specifying the types, so these usages were
generally unnecessary, particularly when the type is enforced by the
array declaration.
 2020-07-16 21:59:25 -04:00
Lioncash 502dbfb9eb macro: Resolve missing parameter in doxygen comment 
Resolves a -Wdocumentation warning.
 2020-07-16 21:54:42 -04:00
David 7c970132b5
macro: Add support for "middle methods" on the code cache (#4112) 
Macro code is just uploaded sequentially from a starting address, however that does not mean the entry point for the macro is at that address. This PR adds preliminary support for executing macros in the middle of our cached code.
 2020-06-30 02:32:24 -03:00
David Marcec f5e2aec422 addressed issues 2020-06-24 12:18:33 +10:00
David Marcec 52340e94ac clear mme draw mode 
We already draw, so we can clear it
 2020-06-24 12:09:04 +10:00
David Marcec fabdf5d385 Addressed issues 2020-06-24 12:09:03 +10:00
David Marcec 74b4334d51 Fix constbuffer for 0217920100488FF7 2020-06-24 12:09:02 +10:00
David Marcec 6ce5f3120b Macro HLE support 2020-06-24 12:09:01 +10:00
bunnei 14a1181a97
Merge pull request #4122 from lioncash/hide 
video_core: Eliminate some variable shadowing
 2020-06-21 22:38:04 -04:00
MerryMage c12eb814b4 macro_jit_x64: Use ecx for shift register 
shl/shr only accept cl as their second argument
 2020-06-20 22:24:05 +01:00
merry 928e9c09aa
Merge pull request #4125 from lioncash/macro-shift 
macro_jit_x64: Amend readability of Compile_ExtractShiftLeftRegister()
 2020-06-20 16:08:23 +01:00
merry 2bd903e021
Merge pull request #4123 from lioncash/unused-var 
macro_jit_x64: Remove unused variable
 2020-06-20 16:07:58 +01:00
Lioncash 5a4e89b901 macro_jit_x64: Correct readability of Compile_ExtractShiftLeftImmediate() 
Previously dst wasn't being used.
 2020-06-19 22:57:23 -04:00
Lioncash 140f953b6a macro_jit_x64: Correct readability of Compile_ExtractShiftLeftRegister() 
Previously dst wasn't being used.
 2020-06-19 22:56:55 -04:00
Lioncash 8ea749c1ca macro_jit_x64: Remove unused variable 
Removes a completely unused label and marks another variable as unused,
given it seems like it has potential uses in the future.
 2020-06-19 22:10:45 -04:00
Lioncash 811bff009e macro_jit_x64: Eliminate variable shadowing in Compile_ProcessResult() 
We can reduce the capture scope so that it's not possible for both "reg"
variables to clash with one another.

While we're at it, we can prevent unnecessary copies while we're at it.
 2020-06-19 21:57:44 -04:00
bunnei 7daea551c0
Merge pull request #4087 from MerryMage/macrojit-inline-Read 
macro_jit_x64: Inline Engines::Maxwell3D::GetRegisterValue
 2020-06-19 21:32:07 -04:00
MerryMage 977ceb4056 macro_jit_x64: Remove unused function Read 2020-06-19 11:39:41 +01:00
bunnei 5a092fb61e
Merge pull request #4090 from MerryMage/macrojit-bugs 
macro_jit_x64: Optimization correctness
 2020-06-18 22:28:17 -04:00
MerryMage 44f10d9b9f macro_jit_x64: Inline Engines::Maxwell3D::GetRegisterValue 2020-06-17 17:17:08 +01:00
bunnei a8ac99b619
Merge pull request #4086 from MerryMage/abi 
xbyak_abi: Cleanup
 2020-06-17 11:20:52 -04:00
MerryMage c409722435 macro_jit_x64: Optimization implicitly assumes same destination 2020-06-17 10:36:36 +01:00
MerryMage a6ddd7c382 macro_jit_x64: Should not skip zero registers for certain ALU ops 
The code generated for these ALU ops assume src_a and src_b are always valid.
 2020-06-17 10:36:34 +01:00
bunnei b660ef6c8a
Merge pull request #4089 from MerryMage/macrojit-cleanup-1 
macro_jit_x64: Cleanup
 2020-06-16 23:44:48 -04:00
MerryMage cf0aad7d6a macro_jit_x64: Remove NEXT_PARAMETER 
Not required, as PARAMETERS can just be incremented directly.
 2020-06-15 21:19:38 +01:00
MerryMage 1799f4e774 macro_jit_x64: Remove unused function Compile_WriteCarry 2020-06-15 21:19:38 +01:00
MerryMage c09a9e5cc7 macro_jit_x64: Select better registers 
All registers are now callee-save registers.

RBX and RBP selected for STATE and RESULT because these are most commonly accessed; this is to avoid the REX prefix.
RBP not used for STATE because there are some SIB restrictions, RBX emits smaller code.
 2020-06-15 21:19:38 +01:00
MerryMage 79aa7b3ace macro_jit_x64: Remove REGISTERS 
Unnecessary since this is just an offset from STATE.
 2020-06-15 21:00:59 +01:00
MerryMage 35db6e1c68 macro_jit_x64: Remove JITState::parameters 
This can be passed in as an argument instead.
 2020-06-15 20:55:02 +01:00
MerryMage 389549b80d macro_jit_x64: Remove METHOD_ADDRESS_64 
Unnecessary variable.
 2020-06-15 20:51:33 +01:00
MerryMage a6a43a5ae0 macro_jit_x64: Remove RESULT_64 
This Reg64 codepath has the exact same behaviour as the Reg32 one.
 2020-06-15 20:35:08 +01:00
MerryMage d563017dfe xbyak_abi: Remove *GPS variants of stack manipulation functions 2020-06-15 18:59:54 +01:00
ReinUsesLisp 6e5d8aac4d video_core/macro_jit_x64: Remove initializer in member variable 
Fix build time issues on gcc. Confirmed through asan that avoiding this
initialization is safe.
 2020-06-15 05:17:55 -03:00
David Marcec eca3d16e54 Default init labels and use initializer list for macro engine 2020-06-04 22:23:07 +10:00
David Marcec 411f5527d4 Mark parameters as const 2020-06-03 16:33:38 +10:00
David Marcec 3a20e74f40 Pass by reference instead of copying parameters 2020-06-02 16:37:06 +10:00
David Marcec 8118ea160b Favor switch case over jump table 
Easier to read and will emit a jump table automatically.
 2020-05-30 12:23:58 +10:00
David Marcec b032ebdfee Implement macro JIT 2020-05-30 11:40:04 +10:00