artemist/yuzu
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity
9219 commits 1 branch 0 tags 106 MiB
Commit graph

445 commits

Author SHA1 Message Date
Lioncash 0d83f8f255 submission_package: Invert conditionals within NSP's constructor to reduce nesting 
We can use early continues here to reduce the amount of nesting.
 2018-10-03 01:11:16 -04:00
Lioncash cf463a9b67 card_image: Ensure program_nca_status is always initialized 
If any of the error paths before the NCA retrieval are taken, it'll
result in program_nca_status being left in an inconsistent state. So we
initialize it by default with a value indicating an error.
 2018-10-02 23:16:05 -04:00
Zach Hilman 215b65fe75 nso: Optimize loading of IPS patches 
Avoid resource-heavy classes and remove quasi-duplicated code.
 2018-10-02 17:03:38 -04:00
Zach Hilman 42fb4e82d3 patch_manager: Add PatchNSO function 
While PatchExeFS operated on the entire directory, this function operates on the uncompressed NSO. Avoids copying decompression code to PatchManager.
 2018-10-01 16:02:50 -04:00
Zach Hilman 4c2a94fa94 patch_manager: Use strings for patch type instead of enum 2018-10-01 16:02:50 -04:00
Zach Hilman 21b2411c44 file_sys: Implement function to apply IPS patches 2018-10-01 16:01:46 -04:00
Zach Hilman f72046099a aoc_u: Extract AccumulateAOCTitleIDs to separate function 2018-09-30 21:07:22 -04:00
Zach Hilman 7d86a008e2 aoc_u: Implement GetAddOnContentBaseId 
Command #5
 2018-09-30 21:01:35 -04:00
Zach Hilman aa0c82e405 romfs_factory: Read from all locations with StorageId None 
Previous behavior was to assert. Seems to mirror expected game behavior.
 2018-09-30 21:01:35 -04:00
Zach Hilman 32fc31fb13 patch_manager: Add DLC recognition to PatchManager 2018-09-30 21:01:35 -04:00
Lioncash cf9d6c6f52 kernel/process: Make data member variables private 
Makes the public interface consistent in terms of how accesses are done
on a process object. It also makes it slightly nicer to reason about the
logic of the process class, as we don't want to expose everything to
external code.
 2018-09-30 02:30:01 -04:00
bunnei f7b69d61f2
Merge pull request #1395 from lioncash/vm 
process/vm_manager: Initial modifications to load NPDM metadata
 2018-09-29 10:54:39 -04:00
Lioncash 861580f6d2 fsmitm_romfsbuild: std::move std::vector instances in Build() 
Avoids making copies of large std::vector instances where it's trivially
avoidable to do so.
 2018-09-26 17:35:44 -04:00
Lioncash 7ecdaaf189 fsmitm_romfsbuild: Replace manual value aligning with Common::AlignUp() 
Theres no need to do explicit bitwise arithmetic here, when we have a
function that does this with a more descriptive name.
 2018-09-26 17:35:21 -04:00
Lioncash 11104b4883 patch_manager: Invert conditionals within ApplyLayeredFS() 
Avoids the need to nest code quite a bit by early-exiting in error
cases.
 2018-09-25 20:09:23 -04:00
Lioncash e3b2ef9170 vfs_vector: Amend initializer list order in VectorVfsFile's constructor initializer list 
Orders the initializer list members to be in the same order that they
would be initialized in. Avoids compiler warnings.
 2018-09-25 20:06:21 -04:00
Lioncash 4654f89618 fsmitm_romfsbuild: Avoid type truncation warnings 
Cast where explicitly necessary and in other cases we can simply modify
the algorithm to accomodate larger data.
 2018-09-25 20:06:21 -04:00
Lioncash 91b56c4928 fsmitm_romfsbuild: Remove unnecessary constructors and initializers for RomFSBuildFileContext and RomFSBuildDirectoryContext 
There's no need to duplicate in-class initializers with a constructor
initializer list. std::strings also initialize to empty by default.
 2018-09-25 20:06:21 -04:00
Lioncash 1f92cbc059 fsmitm_romfsbuild: Remove unnecessary loops in Build() 
The std::vector instances are already initially allocated with all
entries having these values, there's no need to loop through and fill
them with it again when they aren't modified.
 2018-09-25 20:06:21 -04:00
Lioncash fa9e0f9c8b fsmitm_romfsbuild: Make auto variable into a std::size_t variable within Build() 
auto x = 0;

auto-deduces x to be an int. This is undesirable when working with
unsigned values. It also causes sign conversion warnings. Instead, we
can make it a proper unsigned value with the correct width that the
following expressions operate on.
 2018-09-25 20:06:21 -04:00
Lioncash 57616f9758 vfs/etc: Append std:: to size_t usages 
Given we just recently had a patch backport this from citra, let's try
and keep the convention uniform.
 2018-09-25 20:06:21 -04:00
Lioncash 28bef31ea8 vfs_concat/vfs_layered: Remove friend declarations from ConcatenatedVfsFile 
Given these are only added to the class to allow those functions to
access the private constructor, it's a better approach to just make them
static functions in the interface, to make the dependency explicit.
 2018-09-25 20:06:01 -04:00
Lioncash 14e2df5610 vfs_static: Remove template byte parameter from StaticVfsFile 
This converts it into a regular constructor parameter. There's no need
to make this a template parameter on the class when it functions
perfectly well as a constructor argument.

This also reduces the amount of code bloat produced by the compiler, as
it doesn't need to generate the same code for multiple different
instantiations of the same class type, but with a different fill value.
 2018-09-25 17:40:53 -04:00
Lioncash 75603b005b process/vm_manager: Amend API to allow reading parameters from NPDM metadata 
Rather than hard-code the address range to be 36-bit, we can derive the
parameters from supplied NPDM metadata if the supplied exectuable
supports it. This is the bare minimum necessary for this to be possible.

The following commits will rework the memory code further to adjust to
this.
 2018-09-24 17:24:50 -04:00
Zach Hilman b3c2ec362b fsmitm: Cleanup and modernize fsmitm port 2018-09-23 21:50:20 -04:00
Zach Hilman ba0873d33c qt: Add UI elements for LayeredFS and related tools 2018-09-21 19:53:33 -04:00
Zach Hilman 050547b801 romfs: Implement CreateRomFS 2018-09-21 19:53:33 -04:00
Zach Hilman 6eada3c57d file_sys: Port Atmosphere-NX fs_mitm implementation 2018-09-21 19:53:33 -04:00
Zach Hilman 50a470eab8 bis_factory: Add mod directory VFS getter 2018-09-21 19:53:33 -04:00
Zach Hilman 16188acb50 patch_manager: Add LayeredFS mods support 2018-09-21 19:53:33 -04:00
Zach Hilman 44fdac334c vfs_concat: Rewrite and fix ConcatenatedVfsFile 2018-09-21 19:53:33 -04:00
Zach Hilman 3e5c3d0f16 vfs_layered: Add LayeredVfsDirectory 
Reads multiple dirs through as if a waterfall.
 2018-09-21 19:53:05 -04:00
Zach Hilman b52343a428 vfs_vector: Add VectorVfsFile 
Maps a vector into the VFS interface.
 2018-09-21 19:53:05 -04:00
Zach Hilman c65d4d119f vfs_static: Add StaticVfsFile 
Always returns the template argument byte for all reads. Doesn't support writes.
 2018-09-21 19:53:05 -04:00
Zach Hilman f68e324672 vfs: Add and rewite VfsRawCopy functions 2018-09-21 19:53:05 -04:00
Zach Hilman d6cbb3a3e0 vfs: Add GetEntries method 
Maps name string to directory or file.
 2018-09-21 19:53:05 -04:00
bunnei c1c59617ad
Merge pull request #1364 from lioncash/content 
file-sys: Default heavy-weight class destructors in the cpp file
 2018-09-20 23:31:31 -04:00
bunnei 8fe9572271
Merge pull request #1358 from DarkLordZach/temp-storage 
savedata_factory: Add TemporaryStorage SaveDataType
 2018-09-20 10:13:38 -04:00
bunnei 0931a711de
Merge pull request #1363 from lioncash/control 
control_metadata: Move language name array definition to the cpp file
 2018-09-20 10:13:23 -04:00
Lioncash 05ef9dfc10 file-sys: Default heavy-weight class destructors in the cpp file 
Several classes have a lot of non-trivial members within them, or don't
but likely should have the destructor defaulted in the cpp file for
future-proofing/being more friendly to forward declarations.

Leaving the destructor unspecified allows the compiler to inline the
destruction code all over the place, which is generally undesirable from
a code bloat perspective.
 2018-09-19 19:34:08 -04:00
Lioncash 3146502a12 control_metadata: Remove unnecessary else within GetLanguageEntry() 
There's no need to indent the code here, given the if case contains a
return statement at the end of it.
 2018-09-19 19:02:06 -04:00
Lioncash 05d49962b6 control_metadata: Move language name array definition to the cpp file 
This was used in two different translation units
(deconstructed_rom_directory and patch_manager). This means we'd be
pointlessly duplicating the whole array twice due to it being defined
within the header.
 2018-09-19 18:57:26 -04:00
Lioncash 2e5f0e5024 xts_archive: Remove unused variables from CalculateHMAC256() 
These variables aren't used, which still has an impact, as std::vector
cannot be optimized away by the compiler (it's constructor and
destructor are both non-trivial), so this was just wasting memory.
 2018-09-19 14:23:13 -04:00
Lioncash 2752183883 xts_archive: Make AsNCA() return a std::unique_ptr instead of a std::shared_ptr 
std::shared_ptr isn't strictly necessary here and is only ever used in
contexts where the object doesn't depend on being shared. This also
makes the interface more flexible, as it's possible to create a
std::shared_ptr from a std::unique_ptr (std::shared_ptr has a
constructor that accepts a std::unique_ptr), but not the other way
around.
 2018-09-19 14:22:37 -04:00
Lioncash f272261c21 xts_archive: Ensure NAX's type member is always initialized 
Ensures that the member always has a deterministic value.
 2018-09-19 14:22:37 -04:00
Lioncash 92a98a8b19 xts_archive: Amend initializer order of NAX's constructor 
Orders the initializer list in the same order the members would be
initialized. Avoids compiler warnings.
 2018-09-19 14:22:30 -04:00
Zach Hilman dfaea55be5 savedata_factory: Add TemporaryStorage SaveDataType 
Seems to be used by NSO NES Emulator
 2018-09-19 09:06:22 -04:00
fearlessTobi 63c2e32e20 Port #4182 from Citra: "Prefix all size_t with std::" 2018-09-15 15:21:06 +02:00
Lioncash 54724fe918 file_sys/nca_patch: Amend constructor initializer list order 
Orders the elements in the initializer list in the order they're
specified in the class. This prevents compiler warnings about
initialization order.
 2018-09-06 14:00:11 -04:00
Lioncash b155b3ef81 file_sys/nca_patch: Remove unnecessary includes 
romfs.h doesn't need to be included in the header, the only real
dependency here is common's swap.h that needs to be included.
 2018-09-06 13:58:53 -04:00
Lioncash a859a35ec8 file_sys/patch_manager: Add missing includes 
These includes were previously being satisfied indirectly.
 2018-09-06 13:53:23 -04:00
bunnei 94f193af65
Merge pull request #1242 from lioncash/file-sys 
file_sys/submission_package: Replace includes with forward declarations where applicable
 2018-09-05 18:53:32 -04:00
Lioncash 6bd6beee20 file_sys/submission_package: Correct constructor initialization list order 
Orders the elements in the sequence to match the order in which they'll
actually be initialized in.
 2018-09-05 13:44:42 -04:00
Lioncash c0b7ed8b58 file_sys/submission_package: Replace includes with forward declarations where applicable 2018-09-05 12:08:04 -04:00
Zach Hilman c913136eb2 bktr: Fix bucket overlap error 2018-09-04 17:01:54 -04:00
Zach Hilman 23a16c1720 patch_manager: Centralize Control-type NCA parsing 2018-09-04 16:25:10 -04:00
Zach Hilman 92e26df00f nsp: Fix error masking issue with XCI files 
Now display correct error instead of catch-all MissingProgramNCA
 2018-09-04 16:24:24 -04:00
Zach Hilman c91b60a421 game_list: Fix version display on non-NAND titles 2018-09-04 16:24:02 -04:00
Zach Hilman cbd517d8cc bktr: Add logging on successful patch 2018-09-04 16:24:02 -04:00
Zach Hilman a6e75cd45b bktr: Implement IVFC offset shifting 
Fixes base game read errors
 2018-09-04 16:24:02 -04:00
Zach Hilman 9664ce255d bktr: Fix missing includes and optimize style 2018-09-04 16:24:02 -04:00
Zach Hilman 97bf83bc56 patch_manager: Add usages of patches to ExeFS 2018-09-04 16:23:15 -04:00
Zach Hilman 8e900a301a file_sys: Add class to manage game patches 
Right now only includes Updates, but should eventually contain all of the other patches we need.
 2018-09-04 16:22:25 -04:00
Zach Hilman 54e7ddb93a file_sys: Add BKTR patching mechanism 2018-09-04 16:22:25 -04:00
Zach Hilman 1efe5a76b1 content_archive: Add BKTR header parsing to NCA 2018-09-04 16:22:25 -04:00
Zach Hilman 9951f6d054 registration: Add RegisteredCacheUnion 
Aggregates multiple caches into one interface
 2018-09-04 16:21:40 -04:00
Zach Hilman 87be4bc283 main: Only show DRD deprecation warning once 2018-09-04 14:44:48 -04:00
Zach Hilman e973cceadd control_metadata: Use alternate language names if AmericanEnglish isn't available 2018-09-04 14:30:03 -04:00
Zach Hilman 23d2c50479 card_image: Add program title ID getter 2018-09-04 14:29:19 -04:00
Zach Hilman e4e55d064e nsp: Comply with style and performance guidelines 2018-09-04 14:29:19 -04:00
Zach Hilman f7eaea424d registration: Add support for installing NSP files 2018-09-04 14:28:41 -04:00
Zach Hilman 5c8aff984e card_image: Parse XCI secure partition with NSP 
Eliminated duplicate code and adds support for Rev1+ carts
 2018-09-04 14:27:33 -04:00
Zach Hilman 93703431e2 file_sys: Add Nintendo Submission Package (NSP) 2018-09-04 14:25:54 -04:00
Lioncash a813c10e1c file_sys: Replace includes with forward declarations where applicable 
Cuts down on include dependencies, resulting in less files that need to
be rebuilt when certain things are changed.
 2018-09-03 22:52:24 -04:00
Lioncash a405373144 vfs_real: Forward declare IOFile 
Eliminates the need to rebuild some source files if the file_util header
ever changes. This also uncovered some indirect inclusions, which have
also been fixed.
 2018-09-02 12:38:14 -04:00
Lioncash 4a587b81b2 core/core: Replace includes with forward declarations where applicable 
The follow-up to e2457418da, which
replaces most of the includes in the core header with forward declarations.

This makes it so that if any of the headers the core header was
previously including change, then no one will need to rebuild the bulk
of the core, due to core.h being quite a prevalent inclusion.

This should make turnaround for changes much faster for developers.
 2018-08-31 16:30:14 -04:00
bunnei 90fd03015a
Merge pull request #1188 from lioncash/unused 
vfs_real: Remove unused variable in CreateDirectoryRelative()
 2018-08-27 18:24:23 -04:00
Lioncash c6024379a4 vfs_real: Remove unused variable in CreateDirectoryRelative() 2018-08-27 15:58:23 -04:00
Lioncash d3934d7da7 registered_cache: Get rid of variable shadowing in ProcessFiles() 
Prevents compiler warnings.
 2018-08-27 15:55:56 -04:00
Zach Hilman 6314a799aa file_sys/crypto: Fix missing/unnecessary includes 2018-08-24 22:15:32 -04:00
Zach Hilman d1a6dd61d1 xci: Ignore NCA files with updates in secure 2018-08-23 18:53:37 -04:00
Zach Hilman 4f18c17df7 content_archive: Add update title detection 
This is needed because the title IDs of update NCAs will not use the update title ID. The only sure way to tell is to look for a partition with BKTR crypto.
 2018-08-23 18:53:13 -04:00
Zach Hilman 119ab308b5 key_manager: Create keys dir if it dosen't exist 
On call to WriteKeyToFile, so that the autogenerated file can be written.
 2018-08-23 11:53:30 -04:00
Zach Hilman a7e8d10969 file_sys: Cut down on includes and copies 2018-08-23 11:53:30 -04:00
Zach Hilman 42dc856ce1 crypto: Eliminate magic constants 2018-08-23 11:53:30 -04:00
Zach Hilman ab44192ab0 file_sys: Implement NAX containers 2018-08-23 11:53:30 -04:00
Zach Hilman 8b52d6682a registration: Add GetEntryUnparsed methods 
Returns the file before calling parser on it.
 2018-08-23 11:53:30 -04:00
Zach Hilman 13524578b6 sdmc_factory: Add SDMC RegisteredCache getter 2018-08-23 11:53:30 -04:00
Zach Hilman bf33f80fae vfs: Add GetOrCreateDirectoryRelative method 2018-08-23 11:52:44 -04:00
Zach Hilman c4845df3d4 xts_encryption_layer: Implement XTSEncryptionLayer 2018-08-23 11:52:44 -04:00
Zach Hilman a9dc5a3c10 xci: Fix error masking issue 
Prevents NCA-related errors from being masked into MissingProgramNCA or MissingKeyFile
 2018-08-23 11:52:44 -04:00
bunnei b38d67d940
Merge pull request #1136 from tech4me/master 
qt/main: Port part of citra(#3411), open savedata works
 2018-08-22 01:30:08 -04:00
Lioncash 29ac15d1b8 vfs: Replace mode.h include with forward declarations where applicable 
Avoids the need to rebuild these source files if the mode header
changes.
 2018-08-21 15:06:42 -04:00
Lioncash bfb28c5b3f sdmc_factory: Remove unnecessary core include 
This doesn't require the central core header to be included, it just
needs the vfs headers.
 2018-08-21 07:54:29 -04:00
tech4me cc71832b19 qt/main: Port part of citra(#3411), open savedata works 2018-08-21 02:04:33 -07:00
Lioncash 477eee3993 service/filesystem: Use forward declarations where applicable 
Avoids the need to rebuild multiple source files if the filesystem code
headers change.

This also gets rid of a few instances of indirect inclusions being
relied upon
 2018-08-20 23:28:46 -04:00
Lioncash 96463d0a55 romfs_factory: Remove unnecessary includes and use forward declarations where applicable 
Avoids the need to rebuild whatever includes the romfs factory header if
the loader header ever changes. We also don't need to include the main
core header. We can instead include the headers we specifically need.
 2018-08-20 20:27:00 -04:00
Zach Hilman e8cb6f5c9b registration: Add Data_Unknown5 NCAContentType 2018-08-20 17:34:18 -04:00
Zach Hilman 27da7bc9da filesystem: Add support for loading of system archives 2018-08-18 21:28:23 -04:00
Lioncash b39cd70cd4 common: Namespace hex_util.h/.cpp 
It's in the common code, so it should be under the Common namespace like
everything else.
 2018-08-15 23:24:00 -04:00