artemist/yuzu
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

shader/arithmetic_integer: Fix edge case and mark IADD.X Rd.CC as unimplemented

Browse source 
IADD.X Rd.CC requires some extra logic that is not currently
implemented. Abort when this is hit.
This commit is contained in:
ReinUsesLisp 2020-04-25 22:53:54 -03:00
parent 2a96bea6a7
commit e895a4e2d7
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/video_core/shader/decode/arithmetic_integer.cpp
View file

@ -35,7 +35,8 @@ u32 ShaderIR::DecodeArithmeticInteger(NodeBlock& bb, u32 pc) {
case OpCode::Id::IADD_C: case OpCode::Id::IADD_C:
case OpCode::Id::IADD_R: case OpCode::Id::IADD_R:
case OpCode::Id::IADD_IMM: { case OpCode::Id::IADD_IMM: {
UNIMPLEMENTED_IF_MSG(instr.alu.saturate_d, "IADD saturation not implemented"); UNIMPLEMENTED_IF_MSG(instr.alu.saturate_d, "IADD.SAT");
UNIMPLEMENTED_IF_MSG(instr.iadd.x && instr.generates_cc, "IADD.X Rd.CC");
op_a = GetOperandAbsNegInteger(op_a, false, instr.alu_integer.negate_a, true); op_a = GetOperandAbsNegInteger(op_a, false, instr.alu_integer.negate_a, true);
op_b = GetOperandAbsNegInteger(op_b, false, instr.alu_integer.negate_b, true); op_b = GetOperandAbsNegInteger(op_b, false, instr.alu_integer.negate_b, true);
@ -49,6 +50,10 @@ u32 ShaderIR::DecodeArithmeticInteger(NodeBlock& bb, u32 pc) {
} }
if (instr.generates_cc) { if (instr.generates_cc) {
// Avoid changing result's carry flag
SetTemporary(bb, 0, std::move(value));
value = GetTemporary(0);
const Node i0 = Immediate(0); const Node i0 = Immediate(0);
Node zero = Operation(OperationCode::LogicalIEqual, value, i0); Node zero = Operation(OperationCode::LogicalIEqual, value, i0);