artemist/yuzu
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

gl_shader_decompiler: Utilize fmt overload of AddLine() where applicable

Browse source
This commit is contained in:
Lioncash 2019-05-14 12:18:07 -04:00
parent 91ec251c4a
commit 784d2b6c3d
1 changed files with 157 additions and 141 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

298
src/video_core/renderer_opengl/gl_shader_decompiler.cpp
View file

@ -178,17 +178,17 @@ public:
DeclareSamplers(); DeclareSamplers();
DeclarePhysicalAttributeReader(); DeclarePhysicalAttributeReader();
code.AddLine("void execute_" + suffix + "() {"); code.AddLine("void execute_{}() {{", suffix);
++code.scope; ++code.scope;
// VM's program counter // VM's program counter
const auto first_address = ir.GetBasicBlocks().begin()->first; const auto first_address = ir.GetBasicBlocks().begin()->first;
code.AddLine("uint jmp_to = " + std::to_string(first_address) + "u;"); code.AddLine("uint jmp_to = {}u;", first_address);
// TODO(Subv): Figure out the actual depth of the flow stack, for now it seems // TODO(Subv): Figure out the actual depth of the flow stack, for now it seems
// unlikely that shaders will use 20 nested SSYs and PBKs. // unlikely that shaders will use 20 nested SSYs and PBKs.
constexpr u32 FLOW_STACK_SIZE = 20; constexpr u32 FLOW_STACK_SIZE = 20;
code.AddLine(fmt::format("uint flow_stack[{}];", FLOW_STACK_SIZE)); code.AddLine("uint flow_stack[{}];", FLOW_STACK_SIZE);
code.AddLine("uint flow_stack_top = 0u;"); code.AddLine("uint flow_stack_top = 0u;");
code.AddLine("while (true) {"); code.AddLine("while (true) {");
@ -198,7 +198,7 @@ public:
for (const auto& pair : ir.GetBasicBlocks()) { for (const auto& pair : ir.GetBasicBlocks()) {
const auto [address, bb] = pair; const auto [address, bb] = pair;
code.AddLine(fmt::format("case 0x{:x}u: {{", address)); code.AddLine("case 0x{:x}u: {{", address);
++code.scope; ++code.scope;
VisitBlock(bb); VisitBlock(bb);
@ -252,12 +252,13 @@ private:
} }
void DeclareGeometry() { void DeclareGeometry() {
if (stage != ShaderStage::Geometry) if (stage != ShaderStage::Geometry) {
return; return;
}
const auto topology = GetTopologyName(header.common3.output_topology); const auto topology = GetTopologyName(header.common3.output_topology);
const auto max_vertices = std::to_string(header.common4.max_output_vertices); const auto max_vertices = header.common4.max_output_vertices.Value();
code.AddLine("layout (" + topology + ", max_vertices = " + max_vertices + ") out;"); code.AddLine("layout ({}, max_vertices = {}) out;", topology, max_vertices);
code.AddNewLine(); code.AddNewLine();
DeclareVertexRedeclarations(); DeclareVertexRedeclarations();
@ -289,33 +290,35 @@ private:
void DeclareRegisters() { void DeclareRegisters() {
const auto& registers = ir.GetRegisters(); const auto& registers = ir.GetRegisters();
for (const u32 gpr : registers) { for (const u32 gpr : registers) {
code.AddLine("float " + GetRegister(gpr) + " = 0;"); code.AddLine("float {} = 0;", GetRegister(gpr));
} }
if (!registers.empty()) if (!registers.empty()) {
code.AddNewLine(); code.AddNewLine();
}
} }
void DeclarePredicates() { void DeclarePredicates() {
const auto& predicates = ir.GetPredicates(); const auto& predicates = ir.GetPredicates();
for (const auto pred : predicates) { for (const auto pred : predicates) {
code.AddLine("bool " + GetPredicate(pred) + " = false;"); code.AddLine("bool {} = false;", GetPredicate(pred));
} }
if (!predicates.empty()) if (!predicates.empty()) {
code.AddNewLine(); code.AddNewLine();
}
} }
void DeclareLocalMemory() { void DeclareLocalMemory() {
if (const u64 local_memory_size = header.GetLocalMemorySize(); local_memory_size > 0) { if (const u64 local_memory_size = header.GetLocalMemorySize(); local_memory_size > 0) {
const auto element_count = Common::AlignUp(local_memory_size, 4) / 4; const auto element_count = Common::AlignUp(local_memory_size, 4) / 4;
code.AddLine("float " + GetLocalMemory() + '[' + std::to_string(element_count) + "];"); code.AddLine("float {}[{}];", GetLocalMemory(), element_count);
code.AddNewLine(); code.AddNewLine();
} }
} }
void DeclareInternalFlags() { void DeclareInternalFlags() {
for (u32 flag = 0; flag < static_cast<u32>(InternalFlag::Amount); flag++) { for (u32 flag = 0; flag < static_cast<u32>(InternalFlag::Amount); flag++) {
const InternalFlag flag_code = static_cast<InternalFlag>(flag); const auto flag_code = static_cast<InternalFlag>(flag);
code.AddLine("bool " + GetInternalFlag(flag_code) + " = false;"); code.AddLine("bool {} = false;", GetInternalFlag(flag_code));
} }
code.AddNewLine(); code.AddNewLine();
} }
@ -354,8 +357,9 @@ private:
DeclareInputAttribute(index, false); DeclareInputAttribute(index, false);
} }
} }
if (!attributes.empty()) if (!attributes.empty()) {
code.AddNewLine(); code.AddNewLine();
}
} }
void DeclareInputAttribute(Attribute::Index index, bool skip_unused) { void DeclareInputAttribute(Attribute::Index index, bool skip_unused) {
@ -381,8 +385,7 @@ private:
location += GENERIC_VARYING_START_LOCATION; location += GENERIC_VARYING_START_LOCATION;
} }
code.AddLine("layout (location = " + std::to_string(location) + ") " + suffix + "in vec4 " + code.AddLine("layout (location = {}) {} in vec4 {};", name, location, suffix, name);
name + ';');
} }
void DeclareOutputAttributes() { void DeclareOutputAttributes() {
@ -400,22 +403,22 @@ private:
DeclareOutputAttribute(index); DeclareOutputAttribute(index);
} }
} }
if (!attributes.empty()) if (!attributes.empty()) {
code.AddNewLine(); code.AddNewLine();
}
} }
void DeclareOutputAttribute(Attribute::Index index) { void DeclareOutputAttribute(Attribute::Index index) {
const u32 location{GetGenericAttributeIndex(index) + GENERIC_VARYING_START_LOCATION}; const u32 location{GetGenericAttributeIndex(index) + GENERIC_VARYING_START_LOCATION};
code.AddLine("layout (location = " + std::to_string(location) + ") out vec4 " + code.AddLine("layout (location = {}) out vec4 {};", location, GetOutputAttribute(index));
GetOutputAttribute(index) + ';');
} }
void DeclareConstantBuffers() { void DeclareConstantBuffers() {
for (const auto& entry : ir.GetConstantBuffers()) { for (const auto& entry : ir.GetConstantBuffers()) {
const auto [index, size] = entry; const auto [index, size] = entry;
code.AddLine("layout (std140, binding = CBUF_BINDING_" + std::to_string(index) + code.AddLine("layout (std140, binding = CBUF_BINDING_{}) uniform {} {{", index,
") uniform " + GetConstBufferBlock(index) + " {"); GetConstBufferBlock(index));
code.AddLine(" vec4 " + GetConstBuffer(index) + "[MAX_CONSTBUFFER_ELEMENTS];"); code.AddLine(" vec4 {}[MAX_CONSTBUFFER_ELEMENTS];", GetConstBuffer(index));
code.AddLine("};"); code.AddLine("};");
code.AddNewLine(); code.AddNewLine();
} }
@ -428,16 +431,15 @@ private:
// Since we don't know how the shader will use the shader, hint the driver to disable as // Since we don't know how the shader will use the shader, hint the driver to disable as
// much optimizations as possible // much optimizations as possible
std::string qualifier = "coherent volatile"; std::string qualifier = "coherent volatile";
if (usage.is_read && !usage.is_written) if (usage.is_read && !usage.is_written) {
qualifier += " readonly"; qualifier += " readonly";
else if (usage.is_written && !usage.is_read) } else if (usage.is_written && !usage.is_read) {
qualifier += " writeonly"; qualifier += " writeonly";
}
const std::string binding = code.AddLine("layout (std430, binding = GMEM_BINDING_{}_{}) {} buffer {} {{",
fmt::format("GMEM_BINDING_{}_{}", base.cbuf_index, base.cbuf_offset); base.cbuf_index, base.cbuf_offset, qualifier, GetGlobalMemoryBlock(base));
code.AddLine("layout (std430, binding = " + binding + ") " + qualifier + " buffer " + code.AddLine(" float {}[];", GetGlobalMemory(base));
GetGlobalMemoryBlock(base) + " {");
code.AddLine(" float " + GetGlobalMemory(base) + "[];");
code.AddLine("};"); code.AddLine("};");
code.AddNewLine(); code.AddNewLine();
} }
@ -446,7 +448,7 @@ private:
void DeclareSamplers() { void DeclareSamplers() {
const auto& samplers = ir.GetSamplers(); const auto& samplers = ir.GetSamplers();
for (const auto& sampler : samplers) { for (const auto& sampler : samplers) {
std::string sampler_type = [&]() { std::string sampler_type = [&sampler] {
switch (sampler.GetType()) { switch (sampler.GetType()) {
case Tegra::Shader::TextureType::Texture1D: case Tegra::Shader::TextureType::Texture1D:
return "sampler1D"; return "sampler1D";
@ -461,25 +463,28 @@ private:
return "sampler2D"; return "sampler2D";
} }
}(); }();
if (sampler.IsArray()) if (sampler.IsArray()) {
sampler_type += "Array"; sampler_type += "Array";
if (sampler.IsShadow()) }
if (sampler.IsShadow()) {
sampler_type += "Shadow"; sampler_type += "Shadow";
}
code.AddLine("layout (binding = SAMPLER_BINDING_" + std::to_string(sampler.GetIndex()) + code.AddLine("layout (binding = SAMPLER_BINDING_{}) uniform {} {};", sampler.GetIndex(),
") uniform " + sampler_type + ' ' + GetSampler(sampler) + ';'); sampler_type, GetSampler(sampler));
} }
if (!samplers.empty()) if (!samplers.empty()) {
code.AddNewLine(); code.AddNewLine();
}
} }
void DeclarePhysicalAttributeReader() { void DeclarePhysicalAttributeReader() {
if (!ir.HasPhysicalAttributes()) { if (!ir.HasPhysicalAttributes()) {
return; return;
} }
code.AddLine("float readPhysicalAttribute(uint physical_address) {"); code.AddLine("float readPhysicalAttribute(uint physical_address) {{");
++code.scope; ++code.scope;
code.AddLine("switch (physical_address) {"); code.AddLine("switch (physical_address) {{");
// Just declare generic attributes for now. // Just declare generic attributes for now.
const auto num_attributes{static_cast<u32>(GetNumPhysicalInputAttributes())}; const auto num_attributes{static_cast<u32>(GetNumPhysicalInputAttributes())};
@ -494,15 +499,15 @@ private:
const bool declared{stage != ShaderStage::Fragment || const bool declared{stage != ShaderStage::Fragment ||
header.ps.GetAttributeUse(index) != AttributeUse::Unused}; header.ps.GetAttributeUse(index) != AttributeUse::Unused};
const std::string value{declared ? ReadAttribute(attribute, element) : "0"}; const std::string value{declared ? ReadAttribute(attribute, element) : "0"};
code.AddLine(fmt::format("case 0x{:x}: return {};", address, value)); code.AddLine("case 0x{:x}: return {};", address, value);
} }
} }
code.AddLine("default: return 0;"); code.AddLine("default: return 0;");
code.AddLine('}'); code.AddLine("}}");
--code.scope; --code.scope;
code.AddLine('}'); code.AddLine("}}");
code.AddNewLine(); code.AddNewLine();
} }
@ -527,23 +532,26 @@ private:
return {}; return {};
} }
return (this->*decompiler)(*operation); return (this->*decompiler)(*operation);
}
} else if (const auto gpr = std::get_if<GprNode>(node)) { if (const auto gpr = std::get_if<GprNode>(node)) {
const u32 index = gpr->GetIndex(); const u32 index = gpr->GetIndex();
if (index == Register::ZeroIndex) { if (index == Register::ZeroIndex) {
return "0"; return "0";
} }
return GetRegister(index); return GetRegister(index);
}
} else if (const auto immediate = std::get_if<ImmediateNode>(node)) { if (const auto immediate = std::get_if<ImmediateNode>(node)) {
const u32 value = immediate->GetValue(); const u32 value = immediate->GetValue();
if (value < 10) { if (value < 10) {
// For eyecandy avoid using hex numbers on single digits // For eyecandy avoid using hex numbers on single digits
return fmt::format("utof({}u)", immediate->GetValue()); return fmt::format("utof({}u)", immediate->GetValue());
} }
return fmt::format("utof(0x{:x}u)", immediate->GetValue()); return fmt::format("utof(0x{:x}u)", immediate->GetValue());
}
} else if (const auto predicate = std::get_if<PredicateNode>(node)) { if (const auto predicate = std::get_if<PredicateNode>(node)) {
const auto value = [&]() -> std::string { const auto value = [&]() -> std::string {
switch (const auto index = predicate->GetIndex(); index) { switch (const auto index = predicate->GetIndex(); index) {
case Tegra::Shader::Pred::UnusedIndex: case Tegra::Shader::Pred::UnusedIndex:
@ -555,19 +563,22 @@ private:
} }
}(); }();
if (predicate->IsNegated()) { if (predicate->IsNegated()) {
return "!(" + value + ')'; return fmt::format("!({})", value);
} }
return value; return value;
}
} else if (const auto abuf = std::get_if<AbufNode>(node)) { if (const auto abuf = std::get_if<AbufNode>(node)) {
UNIMPLEMENTED_IF_MSG(abuf->IsPhysicalBuffer() && stage == ShaderStage::Geometry, UNIMPLEMENTED_IF_MSG(abuf->IsPhysicalBuffer() && stage == ShaderStage::Geometry,
"Physical attributes in geometry shaders are not implemented"); "Physical attributes in geometry shaders are not implemented");
if (abuf->IsPhysicalBuffer()) { if (abuf->IsPhysicalBuffer()) {
return "readPhysicalAttribute(ftou(" + Visit(abuf->GetPhysicalAddress()) + "))"; return fmt::format("readPhysicalAttribute(ftou({}))",
Visit(abuf->GetPhysicalAddress()));
} }
return ReadAttribute(abuf->GetIndex(), abuf->GetElement(), abuf->GetBuffer()); return ReadAttribute(abuf->GetIndex(), abuf->GetElement(), abuf->GetBuffer());
}
} else if (const auto cbuf = std::get_if<CbufNode>(node)) { if (const auto cbuf = std::get_if<CbufNode>(node)) {
const Node offset = cbuf->GetOffset(); const Node offset = cbuf->GetOffset();
if (const auto immediate = std::get_if<ImmediateNode>(offset)) { if (const auto immediate = std::get_if<ImmediateNode>(offset)) {
// Direct access // Direct access
@ -575,33 +586,37 @@ private:
ASSERT_MSG(offset_imm % 4 == 0, "Unaligned cbuf direct access"); ASSERT_MSG(offset_imm % 4 == 0, "Unaligned cbuf direct access");
return fmt::format("{}[{}][{}]", GetConstBuffer(cbuf->GetIndex()), return fmt::format("{}[{}][{}]", GetConstBuffer(cbuf->GetIndex()),
offset_imm / (4 * 4), (offset_imm / 4) % 4); offset_imm / (4 * 4), (offset_imm / 4) % 4);
} else if (std::holds_alternative<OperationNode>(*offset)) {
// Indirect access
const std::string final_offset = code.GenerateTemporary();
code.AddLine("uint " + final_offset + " = (ftou(" + Visit(offset) + ") / 4);");
return fmt::format("{}[{} / 4][{} % 4]", GetConstBuffer(cbuf->GetIndex()),
final_offset, final_offset);
} else {
UNREACHABLE_MSG("Unmanaged offset node type");
} }
} else if (const auto gmem = std::get_if<GmemNode>(node)) { if (std::holds_alternative<OperationNode>(*offset)) {
// Indirect access
const std::string final_offset = code.GenerateTemporary();
code.AddLine("uint {} = (ftou({}) / 4);", final_offset, Visit(offset));
return fmt::format("{}[{} / 4][{} % 4]", GetConstBuffer(cbuf->GetIndex()),
final_offset, final_offset);
}
UNREACHABLE_MSG("Unmanaged offset node type");
}
if (const auto gmem = std::get_if<GmemNode>(node)) {
const std::string real = Visit(gmem->GetRealAddress()); const std::string real = Visit(gmem->GetRealAddress());
const std::string base = Visit(gmem->GetBaseAddress()); const std::string base = Visit(gmem->GetBaseAddress());
const std::string final_offset = "(ftou(" + real + ") - ftou(" + base + ")) / 4"; const std::string final_offset = fmt::format("(ftou({}) - ftou({})) / 4", real, base);
return fmt::format("{}[{}]", GetGlobalMemory(gmem->GetDescriptor()), final_offset); return fmt::format("{}[{}]", GetGlobalMemory(gmem->GetDescriptor()), final_offset);
}
} else if (const auto lmem = std::get_if<LmemNode>(node)) { if (const auto lmem = std::get_if<LmemNode>(node)) {
return fmt::format("{}[ftou({}) / 4]", GetLocalMemory(), Visit(lmem->GetAddress())); return fmt::format("{}[ftou({}) / 4]", GetLocalMemory(), Visit(lmem->GetAddress()));
}
} else if (const auto internal_flag = std::get_if<InternalFlagNode>(node)) { if (const auto internal_flag = std::get_if<InternalFlagNode>(node)) {
return GetInternalFlag(internal_flag->GetFlag()); return GetInternalFlag(internal_flag->GetFlag());
}
} else if (const auto conditional = std::get_if<ConditionalNode>(node)) { if (const auto conditional = std::get_if<ConditionalNode>(node)) {
// It's invalid to call conditional on nested nodes, use an operation instead // It's invalid to call conditional on nested nodes, use an operation instead
code.AddLine("if (" + Visit(conditional->GetCondition()) + ") {"); code.AddLine("if ({}) {{", Visit(conditional->GetCondition()));
++code.scope; ++code.scope;
VisitBlock(conditional->GetCode()); VisitBlock(conditional->GetCode());
@ -609,23 +624,25 @@ private:
--code.scope; --code.scope;
code.AddLine('}'); code.AddLine('}');
return {}; return {};
}
} else if (const auto comment = std::get_if<CommentNode>(node)) { if (const auto comment = std::get_if<CommentNode>(node)) {
return "// " + comment->GetText(); return "// " + comment->GetText();
} }
UNREACHABLE(); UNREACHABLE();
return {}; return {};
} }
std::string ReadAttribute(Attribute::Index attribute, u32 element, Node buffer = {}) { std::string ReadAttribute(Attribute::Index attribute, u32 element, Node buffer = {}) {
const auto GeometryPass = [&](std::string name) { const auto GeometryPass = [&](std::string_view name) {
if (stage == ShaderStage::Geometry && buffer) { if (stage == ShaderStage::Geometry && buffer) {
// TODO(Rodrigo): Guard geometry inputs against out of bound reads. Some games // TODO(Rodrigo): Guard geometry inputs against out of bound reads. Some games
// set an 0x80000000 index for those and the shader fails to build. Find out why // set an 0x80000000 index for those and the shader fails to build. Find out why
// this happens and what's its intent. // this happens and what's its intent.
return "gs_" + std::move(name) + "[ftou(" + Visit(buffer) + ") % MAX_VERTEX_INPUT]"; return fmt::format("gs_{}[ftou({}) % MAX_VERTEX_INPUT]", name, Visit(buffer));
} }
return name; return std::string(name);
}; };
switch (attribute) { switch (attribute) {
@ -688,7 +705,7 @@ private:
const std::string precise = stage != ShaderStage::Fragment ? "precise " : ""; const std::string precise = stage != ShaderStage::Fragment ? "precise " : "";
const std::string temporary = code.GenerateTemporary(); const std::string temporary = code.GenerateTemporary();
code.AddLine(precise + "float " + temporary + " = " + value + ';'); code.AddLine("{}float {} = {};", precise, temporary, value);
return temporary; return temporary;
} }
@ -702,7 +719,7 @@ private:
} }
const std::string temporary = code.GenerateTemporary(); const std::string temporary = code.GenerateTemporary();
code.AddLine("float " + temporary + " = " + Visit(operand) + ';'); code.AddLine("float {} = {};", temporary, Visit(operand));
return temporary; return temporary;
} }
@ -717,31 +734,32 @@ private:
case Type::Float: case Type::Float:
return value; return value;
case Type::Int: case Type::Int:
return "ftoi(" + value + ')'; return fmt::format("ftoi({})", value);
case Type::Uint: case Type::Uint:
return "ftou(" + value + ')'; return fmt::format("ftou({})", value);
case Type::HalfFloat: case Type::HalfFloat:
return "toHalf2(" + value + ')'; return fmt::format("toHalf2({})", value);
} }
UNREACHABLE(); UNREACHABLE();
return value; return value;
} }
std::string BitwiseCastResult(std::string value, Type type, bool needs_parenthesis = false) { std::string BitwiseCastResult(const std::string& value, Type type,
bool needs_parenthesis = false) {
switch (type) { switch (type) {
case Type::Bool: case Type::Bool:
case Type::Bool2: case Type::Bool2:
case Type::Float: case Type::Float:
if (needs_parenthesis) { if (needs_parenthesis) {
return '(' + value + ')'; return fmt::format("({})", value);
} }
return value; return value;
case Type::Int: case Type::Int:
return "itof(" + value + ')'; return fmt::format("itof({})", value);
case Type::Uint: case Type::Uint:
return "utof(" + value + ')'; return fmt::format("utof({})", value);
case Type::HalfFloat: case Type::HalfFloat:
return "fromHalf2(" + value + ')'; return fmt::format("fromHalf2({})", value);
} }
UNREACHABLE(); UNREACHABLE();
return value; return value;
@ -749,27 +767,27 @@ private:
std::string GenerateUnary(Operation operation, const std::string& func, Type result_type, std::string GenerateUnary(Operation operation, const std::string& func, Type result_type,
Type type_a, bool needs_parenthesis = true) { Type type_a, bool needs_parenthesis = true) {
return ApplyPrecise(operation, const std::string op_str = fmt::format("{}({})", func, VisitOperand(operation, 0, type_a));
BitwiseCastResult(func + '(' + VisitOperand(operation, 0, type_a) + ')',
result_type, needs_parenthesis)); return ApplyPrecise(operation, BitwiseCastResult(op_str, result_type, needs_parenthesis));
} }
std::string GenerateBinaryInfix(Operation operation, const std::string& func, Type result_type, std::string GenerateBinaryInfix(Operation operation, const std::string& func, Type result_type,
Type type_a, Type type_b) { Type type_a, Type type_b) {
const std::string op_a = VisitOperand(operation, 0, type_a); const std::string op_a = VisitOperand(operation, 0, type_a);
const std::string op_b = VisitOperand(operation, 1, type_b); const std::string op_b = VisitOperand(operation, 1, type_b);
const std::string op_str = fmt::format("({} {} {})", op_a, func, op_b);
return ApplyPrecise( return ApplyPrecise(operation, BitwiseCastResult(op_str, result_type));
operation, BitwiseCastResult('(' + op_a + ' ' + func + ' ' + op_b + ')', result_type));
} }
std::string GenerateBinaryCall(Operation operation, const std::string& func, Type result_type, std::string GenerateBinaryCall(Operation operation, const std::string& func, Type result_type,
Type type_a, Type type_b) { Type type_a, Type type_b) {
const std::string op_a = VisitOperand(operation, 0, type_a); const std::string op_a = VisitOperand(operation, 0, type_a);
const std::string op_b = VisitOperand(operation, 1, type_b); const std::string op_b = VisitOperand(operation, 1, type_b);
const std::string op_str = fmt::format("{}({}, {})", func, op_a, op_b);
return ApplyPrecise(operation, return ApplyPrecise(operation, BitwiseCastResult(op_str, result_type));
BitwiseCastResult(func + '(' + op_a + ", " + op_b + ')', result_type));
} }
std::string GenerateTernary(Operation operation, const std::string& func, Type result_type, std::string GenerateTernary(Operation operation, const std::string& func, Type result_type,
@ -777,10 +795,9 @@ private:
const std::string op_a = VisitOperand(operation, 0, type_a); const std::string op_a = VisitOperand(operation, 0, type_a);
const std::string op_b = VisitOperand(operation, 1, type_b); const std::string op_b = VisitOperand(operation, 1, type_b);
const std::string op_c = VisitOperand(operation, 2, type_c); const std::string op_c = VisitOperand(operation, 2, type_c);
const std::string op_str = fmt::format("{}({}, {}, {})", func, op_a, op_b, op_c);
return ApplyPrecise( return ApplyPrecise(operation, BitwiseCastResult(op_str, result_type));
operation,
BitwiseCastResult(func + '(' + op_a + ", " + op_b + ", " + op_c + ')', result_type));
} }
std::string GenerateQuaternary(Operation operation, const std::string& func, Type result_type, std::string GenerateQuaternary(Operation operation, const std::string& func, Type result_type,
@ -789,10 +806,9 @@ private:
const std::string op_b = VisitOperand(operation, 1, type_b); const std::string op_b = VisitOperand(operation, 1, type_b);
const std::string op_c = VisitOperand(operation, 2, type_c); const std::string op_c = VisitOperand(operation, 2, type_c);
const std::string op_d = VisitOperand(operation, 3, type_d); const std::string op_d = VisitOperand(operation, 3, type_d);
const std::string op_str = fmt::format("{}({}, {}, {}, {})", func, op_a, op_b, op_c, op_d);
return ApplyPrecise(operation, BitwiseCastResult(func + '(' + op_a + ", " + op_b + ", " + return ApplyPrecise(operation, BitwiseCastResult(op_str, result_type));
op_c + ", " + op_d + ')',
result_type));
} }
std::string GenerateTexture(Operation operation, const std::string& function_suffix, std::string GenerateTexture(Operation operation, const std::string& function_suffix,
@ -855,7 +871,7 @@ private:
// required to be constant) // required to be constant)
expr += std::to_string(static_cast<s32>(immediate->GetValue())); expr += std::to_string(static_cast<s32>(immediate->GetValue()));
} else { } else {
expr += "ftoi(" + Visit(operand) + ')'; expr += fmt::format("ftoi({})", Visit(operand));
} }
break; break;
case Type::Float: case Type::Float:
@ -888,7 +904,7 @@ private:
expr += std::to_string(static_cast<s32>(immediate->GetValue())); expr += std::to_string(static_cast<s32>(immediate->GetValue()));
} else if (device.HasVariableAoffi()) { } else if (device.HasVariableAoffi()) {
// Avoid using variable AOFFI on unsupported devices. // Avoid using variable AOFFI on unsupported devices.
expr += "ftoi(" + Visit(operand) + ')'; expr += fmt::format("ftoi({})", Visit(operand));
} else { } else {
// Insert 0 on devices not supporting variable AOFFI. // Insert 0 on devices not supporting variable AOFFI.
expr += '0'; expr += '0';
@ -913,7 +929,6 @@ private:
return {}; return {};
} }
target = GetRegister(gpr->GetIndex()); target = GetRegister(gpr->GetIndex());
} else if (const auto abuf = std::get_if<AbufNode>(dest)) { } else if (const auto abuf = std::get_if<AbufNode>(dest)) {
UNIMPLEMENTED_IF(abuf->IsPhysicalBuffer()); UNIMPLEMENTED_IF(abuf->IsPhysicalBuffer());
@ -924,9 +939,9 @@ private:
case Attribute::Index::PointSize: case Attribute::Index::PointSize:
return "gl_PointSize"; return "gl_PointSize";
case Attribute::Index::ClipDistances0123: case Attribute::Index::ClipDistances0123:
return "gl_ClipDistance[" + std::to_string(abuf->GetElement()) + ']'; return fmt::format("gl_ClipDistance[{}]", abuf->GetElement());
case Attribute::Index::ClipDistances4567: case Attribute::Index::ClipDistances4567:
return "gl_ClipDistance[" + std::to_string(abuf->GetElement() + 4) + ']'; return fmt::format("gl_ClipDistance[{}]", abuf->GetElement() + 4);
default: default:
if (IsGenericAttribute(attribute)) { if (IsGenericAttribute(attribute)) {
return GetOutputAttribute(attribute) + GetSwizzle(abuf->GetElement()); return GetOutputAttribute(attribute) + GetSwizzle(abuf->GetElement());
@ -936,21 +951,18 @@ private:
return "0"; return "0";
} }
}(); }();
} else if (const auto lmem = std::get_if<LmemNode>(dest)) { } else if (const auto lmem = std::get_if<LmemNode>(dest)) {
target = GetLocalMemory() + "[ftou(" + Visit(lmem->GetAddress()) + ") / 4]"; target = fmt::format("{}[ftou({}) / 4]", GetLocalMemory(), Visit(lmem->GetAddress()));
} else if (const auto gmem = std::get_if<GmemNode>(dest)) { } else if (const auto gmem = std::get_if<GmemNode>(dest)) {
const std::string real = Visit(gmem->GetRealAddress()); const std::string real = Visit(gmem->GetRealAddress());
const std::string base = Visit(gmem->GetBaseAddress()); const std::string base = Visit(gmem->GetBaseAddress());
const std::string final_offset = "(ftou(" + real + ") - ftou(" + base + ")) / 4"; const std::string final_offset = fmt::format("(ftou({}) - ftou({})) / 4", real, base);
target = fmt::format("{}[{}]", GetGlobalMemory(gmem->GetDescriptor()), final_offset); target = fmt::format("{}[{}]", GetGlobalMemory(gmem->GetDescriptor()), final_offset);
} else { } else {
UNREACHABLE_MSG("Assign called without a proper target"); UNREACHABLE_MSG("Assign called without a proper target");
} }
code.AddLine(target + " = " + Visit(src) + ';'); code.AddLine("{} = {};", target, Visit(src));
return {}; return {};
} }
@ -1003,8 +1015,9 @@ private:
const std::string condition = Visit(operation[0]); const std::string condition = Visit(operation[0]);
const std::string true_case = Visit(operation[1]); const std::string true_case = Visit(operation[1]);
const std::string false_case = Visit(operation[2]); const std::string false_case = Visit(operation[2]);
return ApplyPrecise(operation, const std::string op_str = fmt::format("({} ? {} : {})", condition, true_case, false_case);
'(' + condition + " ? " + true_case + " : " + false_case + ')');
return ApplyPrecise(operation, op_str);
} }
std::string FCos(Operation operation) { std::string FCos(Operation operation) {
@ -1068,9 +1081,9 @@ private:
std::string ILogicalShiftRight(Operation operation) { std::string ILogicalShiftRight(Operation operation) {
const std::string op_a = VisitOperand(operation, 0, Type::Uint); const std::string op_a = VisitOperand(operation, 0, Type::Uint);
const std::string op_b = VisitOperand(operation, 1, Type::Uint); const std::string op_b = VisitOperand(operation, 1, Type::Uint);
const std::string op_str = fmt::format("int({} >> {})", op_a, op_b);
return ApplyPrecise(operation, return ApplyPrecise(operation, BitwiseCastResult(op_str, Type::Int));
BitwiseCastResult("int(" + op_a + " >> " + op_b + ')', Type::Int));
} }
std::string IArithmeticShiftRight(Operation operation) { std::string IArithmeticShiftRight(Operation operation) {
@ -1126,11 +1139,12 @@ private:
} }
std::string HNegate(Operation operation) { std::string HNegate(Operation operation) {
const auto GetNegate = [&](std::size_t index) -> std::string { const auto GetNegate = [&](std::size_t index) {
return VisitOperand(operation, index, Type::Bool) + " ? -1 : 1"; return VisitOperand(operation, index, Type::Bool) + " ? -1 : 1";
}; };
const std::string value = '(' + VisitOperand(operation, 0, Type::HalfFloat) + " * vec2(" + const std::string value =
GetNegate(1) + ", " + GetNegate(2) + "))"; fmt::format("({} * vec2({}, {}))", VisitOperand(operation, 0, Type::HalfFloat),
GetNegate(1), GetNegate(2));
return BitwiseCastResult(value, Type::HalfFloat); return BitwiseCastResult(value, Type::HalfFloat);
} }
@ -1138,7 +1152,8 @@ private:
const std::string value = VisitOperand(operation, 0, Type::HalfFloat); const std::string value = VisitOperand(operation, 0, Type::HalfFloat);
const std::string min = VisitOperand(operation, 1, Type::Float); const std::string min = VisitOperand(operation, 1, Type::Float);
const std::string max = VisitOperand(operation, 2, Type::Float); const std::string max = VisitOperand(operation, 2, Type::Float);
const std::string clamped = "clamp(" + value + ", vec2(" + min + "), vec2(" + max + "))"; const std::string clamped = fmt::format("clamp({}, vec2({}), vec2({}))", value, min, max);
return ApplyPrecise(operation, BitwiseCastResult(clamped, Type::HalfFloat)); return ApplyPrecise(operation, BitwiseCastResult(clamped, Type::HalfFloat));
} }
@ -1149,34 +1164,35 @@ private:
case Tegra::Shader::HalfType::H0_H1: case Tegra::Shader::HalfType::H0_H1:
return operand; return operand;
case Tegra::Shader::HalfType::F32: case Tegra::Shader::HalfType::F32:
return "vec2(fromHalf2(" + operand + "))"; return fmt::format("vec2(fromHalf2({}))", operand);
case Tegra::Shader::HalfType::H0_H0: case Tegra::Shader::HalfType::H0_H0:
return "vec2(" + operand + "[0])"; return fmt::format("vec2({}[0])", operand);
case Tegra::Shader::HalfType::H1_H1: case Tegra::Shader::HalfType::H1_H1:
return "vec2(" + operand + "[1])"; return fmt::format("vec2({}[1])", operand);
} }
UNREACHABLE(); UNREACHABLE();
return "0"; return "0";
}(); }();
return "fromHalf2(" + value + ')'; return fmt::format("fromHalf2({})", value);
} }
std::string HMergeF32(Operation operation) { std::string HMergeF32(Operation operation) {
return "float(toHalf2(" + Visit(operation[0]) + ")[0])"; return fmt::format("float(toHalf2({})[0])", Visit(operation[0]));
} }
std::string HMergeH0(Operation operation) { std::string HMergeH0(Operation operation) {
return "fromHalf2(vec2(toHalf2(" + Visit(operation[1]) + ")[0], toHalf2(" + return fmt::format("fromHalf2(vec2(toHalf2({})[0], toHalf2({})[1]))", Visit(operation[1]),
Visit(operation[0]) + ")[1]))"; Visit(operation[0]));
} }
std::string HMergeH1(Operation operation) { std::string HMergeH1(Operation operation) {
return "fromHalf2(vec2(toHalf2(" + Visit(operation[0]) + ")[0], toHalf2(" + return fmt::format("fromHalf2(vec2(toHalf2({})[0], toHalf2({})[1]))", Visit(operation[0]),
Visit(operation[1]) + ")[1]))"; Visit(operation[1]));
} }
std::string HPack2(Operation operation) { std::string HPack2(Operation operation) {
return "utof(packHalf2x16(vec2(" + Visit(operation[0]) + ", " + Visit(operation[1]) + ")))"; return fmt::format("utof(packHalf2x16(vec2({}, {})))", Visit(operation[0]),
Visit(operation[1]));
} }
template <Type type> template <Type type>
@ -1234,7 +1250,7 @@ private:
target = GetInternalFlag(flag->GetFlag()); target = GetInternalFlag(flag->GetFlag());
} }
code.AddLine(target + " = " + Visit(src) + ';'); code.AddLine("{} = {};", target, Visit(src));
return {}; return {};
} }
@ -1256,7 +1272,7 @@ private:
std::string LogicalPick2(Operation operation) { std::string LogicalPick2(Operation operation) {
const std::string pair = VisitOperand(operation, 0, Type::Bool2); const std::string pair = VisitOperand(operation, 0, Type::Bool2);
return pair + '[' + VisitOperand(operation, 1, Type::Uint) + ']'; return fmt::format("{}[{}]", pair, VisitOperand(operation, 1, Type::Uint));
} }
std::string LogicalAll2(Operation operation) { std::string LogicalAll2(Operation operation) {
@ -1268,15 +1284,15 @@ private:
} }
template <bool with_nan> template <bool with_nan>
std::string GenerateHalfComparison(Operation operation, std::string compare_op) { std::string GenerateHalfComparison(Operation operation, const std::string& compare_op) {
std::string comparison{GenerateBinaryCall(operation, compare_op, Type::Bool2, const std::string comparison{GenerateBinaryCall(operation, compare_op, Type::Bool2,
Type::HalfFloat, Type::HalfFloat)}; Type::HalfFloat, Type::HalfFloat)};
if constexpr (!with_nan) { if constexpr (!with_nan) {
return comparison; return comparison;
} }
return "halfFloatNanComparison(" + comparison + ", " + return fmt::format("halfFloatNanComparison({}, {}, {})", comparison,
VisitOperand(operation, 0, Type::HalfFloat) + ", " + VisitOperand(operation, 0, Type::HalfFloat),
VisitOperand(operation, 1, Type::HalfFloat) + ')'; VisitOperand(operation, 1, Type::HalfFloat));
} }
template <bool with_nan> template <bool with_nan>
@ -1353,12 +1369,12 @@ private:
switch (meta->element) { switch (meta->element) {
case 0: case 0:
case 1: case 1:
return "itof(int(textureSize(" + sampler + ", " + lod + ')' + return fmt::format("itof(int(textureSize({}, {}){}))", sampler, lod,
GetSwizzle(meta->element) + "))"; GetSwizzle(meta->element));
case 2: case 2:
return "0"; return "0";
case 3: case 3:
return "itof(textureQueryLevels(" + sampler + "))"; return fmt::format("itof(textureQueryLevels({}))", sampler);
} }
UNREACHABLE(); UNREACHABLE();
return "0"; return "0";
@ -1369,8 +1385,9 @@ private:
ASSERT(meta); ASSERT(meta);
if (meta->element < 2) { if (meta->element < 2) {
return "itof(int((" + GenerateTexture(operation, "QueryLod", {}) + " * vec2(256))" + return fmt::format("itof(int(({} * vec2(256)){}))",
GetSwizzle(meta->element) + "))"; GenerateTexture(operation, "QueryLod", {}),
GetSwizzle(meta->element));
} }
return "0"; return "0";
} }
@ -1409,7 +1426,7 @@ private:
const auto target = std::get_if<ImmediateNode>(operation[0]); const auto target = std::get_if<ImmediateNode>(operation[0]);
UNIMPLEMENTED_IF(!target); UNIMPLEMENTED_IF(!target);
code.AddLine(fmt::format("jmp_to = 0x{:x}u;", target->GetValue())); code.AddLine("jmp_to = 0x{:x}u;", target->GetValue());
code.AddLine("break;"); code.AddLine("break;");
return {}; return {};
} }
@ -1418,7 +1435,7 @@ private:
const auto target = std::get_if<ImmediateNode>(operation[0]); const auto target = std::get_if<ImmediateNode>(operation[0]);
UNIMPLEMENTED_IF(!target); UNIMPLEMENTED_IF(!target);
code.AddLine(fmt::format("flow_stack[flow_stack_top++] = 0x{:x}u;", target->GetValue())); code.AddLine("flow_stack[flow_stack_top++] = 0x{:x}u;", target->GetValue());
return {}; return {};
} }
@ -1455,8 +1472,7 @@ private:
header.ps.IsColorComponentOutputEnabled(render_target, 1) || header.ps.IsColorComponentOutputEnabled(render_target, 1) ||
header.ps.IsColorComponentOutputEnabled(render_target, 2) || header.ps.IsColorComponentOutputEnabled(render_target, 2) ||
header.ps.IsColorComponentOutputEnabled(render_target, 3)) { header.ps.IsColorComponentOutputEnabled(render_target, 3)) {
code.AddLine( code.AddLine("if (!AlphaFunc({})) discard;", SafeGetRegister(current_reg));
fmt::format("if (!AlphaFunc({})) discard;", SafeGetRegister(current_reg)));
current_reg += 4; current_reg += 4;
} }
} }
@ -1470,8 +1486,8 @@ private:
// TODO(Subv): Figure out how dual-source blending is configured in the Switch. // TODO(Subv): Figure out how dual-source blending is configured in the Switch.
for (u32 component = 0; component < 4; ++component) { for (u32 component = 0; component < 4; ++component) {
if (header.ps.IsColorComponentOutputEnabled(render_target, component)) { if (header.ps.IsColorComponentOutputEnabled(render_target, component)) {
code.AddLine(fmt::format("FragColor{}[{}] = {};", render_target, component, code.AddLine("FragColor{}[{}] = {};", render_target, component,
SafeGetRegister(current_reg))); SafeGetRegister(current_reg));
++current_reg; ++current_reg;
} }
} }
@ -1708,7 +1724,7 @@ private:
const auto index = static_cast<u32>(flag); const auto index = static_cast<u32>(flag);
ASSERT(index < static_cast<u32>(InternalFlag::Amount)); ASSERT(index < static_cast<u32>(InternalFlag::Amount));
return std::string(InternalFlagNames[index]) + '_' + suffix; return fmt::format("{}_{}", InternalFlagNames[index], suffix);
} }
std::string GetSampler(const Sampler& sampler) const { std::string GetSampler(const Sampler& sampler) const {
@ -1716,7 +1732,7 @@ private:
} }
std::string GetDeclarationWithSuffix(u32 index, const std::string& name) const { std::string GetDeclarationWithSuffix(u32 index, const std::string& name) const {
return name + '_' + std::to_string(index) + '_' + suffix; return fmt::format("{}_{}_{}", name, index, suffix);
} }
u32 GetNumPhysicalInputAttributes() const { u32 GetNumPhysicalInputAttributes() const {