artemist/yuzu
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

maxwell_3d: update comments for shadow ram usage

Browse source
This commit is contained in:
namkazy 2020-03-22 11:35:26 +07:00
parent 01af036c1f
commit 7051dc1902
3 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/video_core/engines/maxwell_3d.cpp
View file

@ -160,7 +160,7 @@ void Maxwell3D::CallMethod(const GPU::MethodCall& method_call) {
ASSERT_MSG(method < Regs::NUM_REGS, ASSERT_MSG(method < Regs::NUM_REGS,
"Invalid Maxwell3D register, increase the size of the Regs structure"); "Invalid Maxwell3D register, increase the size of the Regs structure");
// Keep track of the register value in shadow_regs when requested. // Keep track of the register value in shadow_state when requested.
if (regs.shadow_ram_control == Regs::ShadowRamControl::Track || if (regs.shadow_ram_control == Regs::ShadowRamControl::Track ||
regs.shadow_ram_control == Regs::ShadowRamControl::TrackWithFilter) { regs.shadow_ram_control == Regs::ShadowRamControl::TrackWithFilter) {
shadow_state.reg_array[method] = method_call.argument; shadow_state.reg_array[method] = method_call.argument;

4
src/video_core/engines/maxwell_3d.h
View file

@ -532,9 +532,13 @@ public:
}; };
enum class ShadowRamControl : u32 { enum class ShadowRamControl : u32 {
// write value to shadow ram
Track = 0, Track = 0,
// write value to shadow ram ( with validation ??? )
TrackWithFilter = 1, TrackWithFilter = 1,
// only write to real hw register
Passthrough = 2, Passthrough = 2,
// write value from shadow ram to real hw register
Replay = 3, Replay = 3,
}; };

2
src/video_core/macro_interpreter.cpp
View file

@ -328,7 +328,7 @@ void MacroInterpreter::SetMethodAddress(u32 address) {
} }
void MacroInterpreter::Send(u32 value) { void MacroInterpreter::Send(u32 value) {
// Use the tracked value in shadow_regs when requested. // Use the tracked value in shadow_state when requested.
if (method_address.address < Engines::Maxwell3D::Regs::NUM_REGS && if (method_address.address < Engines::Maxwell3D::Regs::NUM_REGS &&
maxwell3d.shadow_state.shadow_ram_control == maxwell3d.shadow_state.shadow_ram_control ==
Engines::Maxwell3D::Regs::ShadowRamControl::Replay) { Engines::Maxwell3D::Regs::ShadowRamControl::Replay) {