From 61434651d82b8ecfe7ed43b72841dfb7325e4ef4 Mon Sep 17 00:00:00 2001
From: Subv <subv2112@gmail.com>
Date: Thu, 4 Dec 2014 15:03:39 -0500
Subject: [PATCH] Semaphores: Addressed some style issues

---
 src/core/hle/kernel/semaphore.cpp | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/core/hle/kernel/semaphore.cpp b/src/core/hle/kernel/semaphore.cpp
index c5c1fbeb3..c7afe49fc 100644
--- a/src/core/hle/kernel/semaphore.cpp
+++ b/src/core/hle/kernel/semaphore.cpp
@@ -57,17 +57,16 @@ public:
 
 /**
  * Creates a semaphore
- * @param handle Reference to handle for the newly created semaphore
  * @param initial_count number of slots reserved for other threads
  * @param max_count maximum number of holders the semaphore can have
  * @param name Optional name of semaphore
- * @return Pointer to new Semaphore object
+ * @return Handle for the newly created semaphore
  */
-Semaphore* CreateSemaphore(Handle& handle, u32 initial_count, 
+Handle CreateSemaphore(u32 initial_count, 
     u32 max_count, const std::string& name) {
 
     Semaphore* semaphore = new Semaphore;
-    handle = g_object_pool.Create(semaphore);
+    Handle handle = g_object_pool.Create(semaphore);
 
     semaphore->initial_count = initial_count;
     // When the semaphore is created, some slots are reserved for other threads,
@@ -76,7 +75,7 @@ Semaphore* CreateSemaphore(Handle& handle, u32 initial_count,
     semaphore->current_usage -= initial_count;
     semaphore->name = name;
 
-    return semaphore;
+    return handle;
 }
 
 ResultCode CreateSemaphore(Handle* handle, u32 initial_count, 
@@ -85,7 +84,7 @@ ResultCode CreateSemaphore(Handle* handle, u32 initial_count,
     if (initial_count > max_count)
         return ResultCode(ErrorDescription::InvalidCombination, ErrorModule::Kernel,
                           ErrorSummary::WrongArgument, ErrorLevel::Permanent);
-    Semaphore* semaphore = CreateSemaphore(*handle, initial_count, max_count, name);
+    *handle = CreateSemaphore(initial_count, max_count, name);
 
     return RESULT_SUCCESS;
 }