artemist/yuzu
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

common/compression: Roll back std::span changes

Browse source 
Seems like all compilers don't support std::span yet.
This commit is contained in:
Lioncash 2020-08-15 05:25:28 -04:00
parent df72480395
commit 1ee060ca0d
5 changed files with 45 additions and 38 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
src/common/lz4_compression.cpp
View file

@ -10,52 +10,53 @@
namespace Common::Compression { namespace Common::Compression {
std::vector<u8> CompressDataLZ4(std::span<const u8> source) { std::vector<u8> CompressDataLZ4(const u8* source, std::size_t source_size) {
ASSERT_MSG(source.size() <= LZ4_MAX_INPUT_SIZE, "Source size exceeds LZ4 maximum input size"); ASSERT_MSG(source_size <= LZ4_MAX_INPUT_SIZE, "Source size exceeds LZ4 maximum input size");
const auto source_size_int = static_cast<int>(source.size()); const auto source_size_int = static_cast<int>(source_size);
const int max_compressed_size = LZ4_compressBound(source_size_int); const auto max_compressed_size = static_cast<std::size_t>(LZ4_compressBound(source_size_int));
std::vector<u8> compressed(max_compressed_size); std::vector<u8> compressed(max_compressed_size);
const int compressed_size = LZ4_compress_default(reinterpret_cast<const char*>(source.data()), const int compressed_size = LZ4_compress_default(
reinterpret_cast<char*>(compressed.data()), reinterpret_cast<const char*>(source), reinterpret_cast<char*>(compressed.data()),
source_size_int, max_compressed_size); source_size_int, static_cast<int>(max_compressed_size));
if (compressed_size <= 0) { if (compressed_size <= 0) {
// Compression failed // Compression failed
return {}; return {};
} }
compressed.resize(compressed_size); compressed.resize(static_cast<std::size_t>(compressed_size));
return compressed; return compressed;
} }
std::vector<u8> CompressDataLZ4HC(std::span<const u8> source, s32 compression_level) { std::vector<u8> CompressDataLZ4HC(const u8* source, std::size_t source_size,
ASSERT_MSG(source.size() <= LZ4_MAX_INPUT_SIZE, "Source size exceeds LZ4 maximum input size"); s32 compression_level) {
ASSERT_MSG(source_size <= LZ4_MAX_INPUT_SIZE, "Source size exceeds LZ4 maximum input size");
compression_level = std::clamp(compression_level, LZ4HC_CLEVEL_MIN, LZ4HC_CLEVEL_MAX); compression_level = std::clamp(compression_level, LZ4HC_CLEVEL_MIN, LZ4HC_CLEVEL_MAX);
const auto source_size_int = static_cast<int>(source.size()); const auto source_size_int = static_cast<int>(source_size);
const int max_compressed_size = LZ4_compressBound(source_size_int); const auto max_compressed_size = static_cast<std::size_t>(LZ4_compressBound(source_size_int));
std::vector<u8> compressed(max_compressed_size); std::vector<u8> compressed(max_compressed_size);
const int compressed_size = LZ4_compress_HC( const int compressed_size = LZ4_compress_HC(
reinterpret_cast<const char*>(source.data()), reinterpret_cast<char*>(compressed.data()), reinterpret_cast<const char*>(source), reinterpret_cast<char*>(compressed.data()),
source_size_int, max_compressed_size, compression_level); source_size_int, static_cast<int>(max_compressed_size), compression_level);
if (compressed_size <= 0) { if (compressed_size <= 0) {
// Compression failed // Compression failed
return {}; return {};
} }
compressed.resize(compressed_size); compressed.resize(static_cast<std::size_t>(compressed_size));
return compressed; return compressed;
} }
std::vector<u8> CompressDataLZ4HCMax(std::span<const u8> source) { std::vector<u8> CompressDataLZ4HCMax(const u8* source, std::size_t source_size) {
return CompressDataLZ4HC(source, LZ4HC_CLEVEL_MAX); return CompressDataLZ4HC(source, source_size, LZ4HC_CLEVEL_MAX);
} }
std::vector<u8> DecompressDataLZ4(const std::vector<u8>& compressed, std::vector<u8> DecompressDataLZ4(const std::vector<u8>& compressed,

19
src/common/lz4_compression.h
View file

@ -4,7 +4,6 @@
#pragma once #pragma once
#include <span>
#include <vector> #include <vector>
#include "common/common_types.h" #include "common/common_types.h"
@ -14,11 +13,12 @@ namespace Common::Compression {
/** /**
* Compresses a source memory region with LZ4 and returns the compressed data in a vector. * Compresses a source memory region with LZ4 and returns the compressed data in a vector.
* *
* @param source the uncompressed source memory region. * @param source The uncompressed source memory region.
* @param source_size The size of the uncompressed source memory region.
* *
* @return the compressed data. * @return the compressed data.
*/ */
[[nodiscard]] std::vector<u8> CompressDataLZ4(std::span<const u8> source); [[nodiscard]] std::vector<u8> CompressDataLZ4(const u8* source, std::size_t source_size);
/** /**
* Utilizes the LZ4 subalgorithm LZ4HC with the specified compression level. Higher compression * Utilizes the LZ4 subalgorithm LZ4HC with the specified compression level. Higher compression
@ -26,21 +26,24 @@ namespace Common::Compression {
* compression level has almost no impact on decompression speed. Data compressed with LZ4HC can * compression level has almost no impact on decompression speed. Data compressed with LZ4HC can
* also be decompressed with the default LZ4 decompression. * also be decompressed with the default LZ4 decompression.
* *
* @param source the uncompressed source memory region. * @param source The uncompressed source memory region.
* @param compression_level the used compression level. Should be between 3 and 12. * @param source_size The size of the uncompressed source memory region.
* @param compression_level The used compression level. Should be between 3 and 12.
* *
* @return the compressed data. * @return the compressed data.
*/ */
[[nodiscard]] std::vector<u8> CompressDataLZ4HC(std::span<const u8> source, s32 compression_level); [[nodiscard]] std::vector<u8> CompressDataLZ4HC(const u8* source, std::size_t source_size,
s32 compression_level);
/** /**
* Utilizes the LZ4 subalgorithm LZ4HC with the highest possible compression level. * Utilizes the LZ4 subalgorithm LZ4HC with the highest possible compression level.
* *
* @param source the uncompressed source memory region. * @param source The uncompressed source memory region.
* @param source_size The size of the uncompressed source memory region
* *
* @return the compressed data. * @return the compressed data.
*/ */
[[nodiscard]] std::vector<u8> CompressDataLZ4HCMax(std::span<const u8> source); [[nodiscard]] std::vector<u8> CompressDataLZ4HCMax(const u8* source, std::size_t source_size);
/** /**
* Decompresses a source memory region with LZ4 and returns the uncompressed data in a vector. * Decompresses a source memory region with LZ4 and returns the uncompressed data in a vector.

12
src/common/zstd_compression.cpp
View file

@ -9,14 +9,14 @@
namespace Common::Compression { namespace Common::Compression {
std::vector<u8> CompressDataZSTD(std::span<const u8> source, s32 compression_level) { std::vector<u8> CompressDataZSTD(const u8* source, std::size_t source_size, s32 compression_level) {
compression_level = std::clamp(compression_level, 1, ZSTD_maxCLevel()); compression_level = std::clamp(compression_level, 1, ZSTD_maxCLevel());
const std::size_t max_compressed_size = ZSTD_compressBound(source.size()); const std::size_t max_compressed_size = ZSTD_compressBound(source_size);
std::vector<u8> compressed(max_compressed_size); std::vector<u8> compressed(max_compressed_size);
const std::size_t compressed_size = ZSTD_compress( const std::size_t compressed_size =
compressed.data(), compressed.size(), source.data(), source.size(), compression_level); ZSTD_compress(compressed.data(), compressed.size(), source, source_size, compression_level);
if (ZSTD_isError(compressed_size)) { if (ZSTD_isError(compressed_size)) {
// Compression failed // Compression failed
@ -28,8 +28,8 @@ std::vector<u8> CompressDataZSTD(std::span<const u8> source, s32 compression_lev
return compressed; return compressed;
} }
std::vector<u8> CompressDataZSTDDefault(std::span<const u8> source) { std::vector<u8> CompressDataZSTDDefault(const u8* source, std::size_t source_size) {
return CompressDataZSTD(source, ZSTD_CLEVEL_DEFAULT); return CompressDataZSTD(source, source_size, ZSTD_CLEVEL_DEFAULT);
} }
std::vector<u8> DecompressDataZSTD(const std::vector<u8>& compressed) { std::vector<u8> DecompressDataZSTD(const std::vector<u8>& compressed) {

14
src/common/zstd_compression.h
View file

@ -4,7 +4,6 @@
#pragma once #pragma once
#include <span>
#include <vector> #include <vector>
#include "common/common_types.h" #include "common/common_types.h"
@ -14,22 +13,25 @@ namespace Common::Compression {
/** /**
* Compresses a source memory region with Zstandard and returns the compressed data in a vector. * Compresses a source memory region with Zstandard and returns the compressed data in a vector.
* *
* @param source the uncompressed source memory region. * @param source The uncompressed source memory region.
* @param compression_level the used compression level. Should be between 1 and 22. * @param source_size The size of the uncompressed source memory region.
* @param compression_level The used compression level. Should be between 1 and 22.
* *
* @return the compressed data. * @return the compressed data.
*/ */
[[nodiscard]] std::vector<u8> CompressDataZSTD(std::span<const u8> source, s32 compression_level); [[nodiscard]] std::vector<u8> CompressDataZSTD(const u8* source, std::size_t source_size,
s32 compression_level);
/** /**
* Compresses a source memory region with Zstandard with the default compression level and returns * Compresses a source memory region with Zstandard with the default compression level and returns
* the compressed data in a vector. * the compressed data in a vector.
* *
* @param source the uncompressed source memory region. * @param source The uncompressed source memory region.
* @param source_size The size of the uncompressed source memory region.
* *
* @return the compressed data. * @return the compressed data.
*/ */
[[nodiscard]] std::vector<u8> CompressDataZSTDDefault(std::span<const u8> source); [[nodiscard]] std::vector<u8> CompressDataZSTDDefault(const u8* source, std::size_t source_size);
/** /**
* Decompresses a source memory region with Zstandard and returns the uncompressed data in a vector. * Decompresses a source memory region with Zstandard and returns the uncompressed data in a vector.

3
src/video_core/renderer_opengl/gl_shader_disk_cache.cpp
View file

@ -422,7 +422,8 @@ void ShaderDiskCacheOpenGL::SavePrecompiledHeaderToVirtualPrecompiledCache() {
void ShaderDiskCacheOpenGL::SaveVirtualPrecompiledFile() { void ShaderDiskCacheOpenGL::SaveVirtualPrecompiledFile() {
precompiled_cache_virtual_file_offset = 0; precompiled_cache_virtual_file_offset = 0;
const std::vector<u8> uncompressed = precompiled_cache_virtual_file.ReadAllBytes(); const std::vector<u8> uncompressed = precompiled_cache_virtual_file.ReadAllBytes();
const std::vector<u8> compressed = Common::Compression::CompressDataZSTDDefault(uncompressed); const std::vector<u8> compressed =
Common::Compression::CompressDataZSTDDefault(uncompressed.data(), uncompressed.size());
const auto precompiled_path{GetPrecompiledPath()}; const auto precompiled_path{GetPrecompiledPath()};
FileUtil::IOFile file(precompiled_path, "wb"); FileUtil::IOFile file(precompiled_path, "wb");