artemist/yuzu
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

render_target: Add missing initializer for size extent

Browse source 
Everything else has a default constructor that does the straightforward
thing of initializing most members to a default value, except for the
size.

We explicitly initialize the size (and others, for consistency), to
prevent potential uninitialized reads from occurring. Particularly given
the largeish surface area that this struct is used in.
This commit is contained in:
Lioncash 2021-07-27 07:41:18 -04:00
parent d6c799494c
commit 00e100de08
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/video_core/texture_cache/render_targets.h
View file

@ -24,10 +24,10 @@ struct RenderTargets {
return std::ranges::any_of(color_buffer_ids, contains) || contains(depth_buffer_id); return std::ranges::any_of(color_buffer_ids, contains) || contains(depth_buffer_id);
} }
std::array<ImageViewId, NUM_RT> color_buffer_ids; std::array<ImageViewId, NUM_RT> color_buffer_ids{};
ImageViewId depth_buffer_id; ImageViewId depth_buffer_id{};
std::array<u8, NUM_RT> draw_buffers{}; std::array<u8, NUM_RT> draw_buffers{};
Extent2D size; Extent2D size{};
}; };
} // namespace VideoCommon } // namespace VideoCommon